Date: Sun, 16 Feb 2020 20:10:54 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Mathieu Arnold <mat@freebsd.org> Cc: Yuri <yuri@rawbw.com>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r526232 - head/x11-wm/hikari Message-ID: <20200216191054.GA60992@KGPE-D16> In-Reply-To: <20200216180010.wmck2ge6rf47crm4@atuin.in.mat.cc> References: <202002151802.01FI2w9m044102@repo.freebsd.org> <81a9cfc3-f1e2-f506-a5d0-fc95d57686f9@rawbw.com> <20200216104806.GA80117@KGPE-D16> <3ac58a2c-ecb7-7614-707e-bb591f29dc23@rawbw.com> <20200216180010.wmck2ge6rf47crm4@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--qMm9M+Fa2AknHoGS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable That's what I thought at first, thanks for confirmation. Otherwise, when I commit a change to one of my ports, I should add: Approved by: me (maintainer) which I didn't notice anyone to use :) On 20-02-16 19:00:10, Mathieu Arnold wrote: > On Sun, Feb 16, 2020 at 08:16:39AM -0800, Yuri wrote: > > On 2020-02-16 02:48, Piotr Kubaj wrote: > > > Is it necessary even for trivial build fixes? > >=20 > >=20 > > If this is an unbreak - then you can commit it and 'Approved by' should= be > > 'portmgr'. > >=20 > > If this is some formatting or trivial fix (license/NO_ARCH/helpers/WWW)= - > > then you can commit it and 'Approved by' should be 'portmgr blanket'. > >=20 > > Otherwise you should ask the maintainer. > >=20 > > But the 'Approved by' line, I think, should always be present when > > MAINTAINER is not you and not ports@ >=20 > You only use Approved by: someone if someone actually approved the > change you are committing. Changes that are covered by the blanket > approval do not require any approval, they are not approved by anyone, > they are just authorized to anyone. >=20 > --=20 > Mathieu Arnold --=20 --qMm9M+Fa2AknHoGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl5Jk74ACgkQelmbhSCD nJ2a3w/9HARWkOwTWLI3/wE+EgIuXli7kaQHVgm25AO1PD40plmaHKP2c5ej1NxD q96fJ+i4AFMNpz+lqgptAA/ixiOwtO+gNnySxJk8WU0jInglcbaAW/X2zmYNsB6r tE2hLimW/mqHmZZPxGjf7qE5+GC5n0WonrnzKAaydNqpTm9pfzyR+zwgCtzczjAp du/VFZRf1B7Z+/XucdOmZZ3levt6MKg/0TFcNUlzZ87vNjTemQLI2YOHBqiF5zR4 inbdsvg5nr6auQHZX545cZuaxi6NoAAXD8DNSCttDZC/4iYHhDNu/+m8t4ZMGgS/ OjiRwB3hJ+qNDb/rdVuSmuGxpmX+oRQHQtf18jscc+NxpaoOnQid0EdTivyWhsWr XW+6ni/B0s1iz+HKvJ2ohlgW9K2fLwR0amROcGQdQR68S15oK6VYvERZEOKDWA/x QlBNqobWIldqXR3tTBm75n7MPI9pRxPeWkEPFsC4BlmZHNGL8LkacuO0MSG3y+QU /wlbXONaxjGBQWOuGe3H7nJlbP5j5cMWXtwqopQP/6c6SGZWddhAiDDmIMhP6wd6 1gJ1e40zFjBJ943MWtRqjX0byvBwPx/FzMfYIYuddvpNmASMWD1bBGkCFJsarL5M CNG3CMRpGDCtJGr+W25eLoqwjYyHPtMoWRxxIfMLNtDWtuMFDlM= =Y4OW -----END PGP SIGNATURE----- --qMm9M+Fa2AknHoGS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200216191054.GA60992>