Date: Tue, 3 Oct 2000 12:40:11 -0400 From: Bill Fumerola <billf@chimesnet.com> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_fw.c Message-ID: <20001003124011.T38472@jade.chc-chimes.com> In-Reply-To: <200010031218.FAA51112@freefall.freebsd.org>; from ru@FreeBSD.org on Tue, Oct 03, 2000 at 05:18:11AM -0700 References: <200010031218.FAA51112@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 03, 2000 at 05:18:11AM -0700, Ruslan Ermilov wrote:
> Modified files:
> sys/netinet ip_fw.c
> Log:
> Added the missing ntohs() conversion when matching IP packet with
> the IP_FW_IF_IPID rule. (We have recently decided to keep the
> ip_id field in network byte order inside the kernel, see revision
> 1.140 of src/sys/netinet/ip_input.c).
Crappy. I haven't been following -current as closely as possible.
> I did not like to have the conversion happen in userland, and I
> think that the similar conversions for fw_tcp(seq|ack|win) should
> be moved out of userland (src/sbin/ipfw/ipfw.c) into the kernel.
That's fine, I was just trying to save CPU (perhaps needlessly) by
doing the conversion when we store it as opposed to when we check it.
--
Bill Fumerola - Network Architect, BOFH / Chimes, Inc.
billf@chimesnet.com / billf@FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001003124011.T38472>