From owner-freebsd-amd64@FreeBSD.ORG  Mon Oct  9 17:46:26 2006
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
X-Original-To: freebsd-amd64@FreeBSD.org
Delivered-To: freebsd-amd64@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 429E016A416
	for <freebsd-amd64@FreeBSD.org>; Mon,  9 Oct 2006 17:46:26 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B88A643D45
	for <freebsd-amd64@FreeBSD.org>; Mon,  9 Oct 2006 17:46:23 +0000 (GMT)
	(envelope-from jkim@FreeBSD.org)
Received: from niksun.com (anuket [10.70.0.5])
	by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k99HkJel071887;
	Mon, 9 Oct 2006 13:46:19 -0400 (EDT) (envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: freebsd-amd64@FreeBSD.org, John-Mark Gurney <gurney_j@resnet.uoregon.edu>
Date: Mon, 9 Oct 2006 13:45:57 -0400
User-Agent: KMail/1.6.2
References: <20061007214336.GJ793@funkthat.com>
In-Reply-To: <20061007214336.GJ793@funkthat.com>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200610091346.02064.jkim@FreeBSD.org>
X-Virus-Scanned: ClamAV 0.88/2015/Mon Oct 9 10:16:43 2006 on
	anuket.mj.niksun.com
X-Virus-Status: Clean
Cc: 
Subject: Re: amd64 agp driver bug?
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Oct 2006 17:46:26 -0000

On Saturday 07 October 2006 05:43 pm, John-Mark Gurney wrote:
> I was looking at the agp driver and the BIOS and Kernel Developer's
> Guide, and noticed that it appears we program the page register
> incorrectly...
>
> Currently we do, in sys/pci/agp_amd64.c:
>         sc->gatt->ag_virtual[offset >> AGP_PAGE_SHIFT] = physical;
>
> but according to Table 38 in the guide, it looks like it should be:
>         sc->gatt->ag_virtual[offset >> AGP_PAGE_SHIFT] =
>             (physical & 0xfffff000) | ((physical >> 28) & 0xff0) |
> 1;
>
> To support physical addresses above 4G...
>
> Has anyone used AGP w/ >4GB of memmory?  I'm also puzzled by the
> fact that the guide says to set bit 0, but we don't do that...

As you can see, this part of the documentation is very 
confusing. :-(  I'll take care of it soon.

Jung-uk Kim