Date: Thu, 11 Mar 2010 22:13:17 +0000 (UTC) From: Juli Mallett <jmallett@FreeBSD.org> To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r205045 - user/jmallett/octeon/sys/mips/cavium/dev/rgmii Message-ID: <201003112213.o2BMDHEp087711@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jmallett Date: Thu Mar 11 22:13:16 2010 New Revision: 205045 URL: http://svn.freebsd.org/changeset/base/205045 Log: Remove a silly comment, remove gratuitous braces. Suggested by: imp Modified: user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Modified: user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c ============================================================================== --- user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Thu Mar 11 22:11:24 2010 (r205044) +++ user/jmallett/octeon/sys/mips/cavium/dev/rgmii/octeon_rgmx.c Thu Mar 11 22:13:16 2010 (r205045) @@ -1768,12 +1768,6 @@ static void octeon_rgmx_init (void *xsc struct rgmx_softc_dev *sc = xsc; octeon_rgmx_rxx_rx_inbnd_t link_status; - /* - * Called mostly from ifnet interface ifp->if_init(); - * I think we can anchor most of our iniialization here and - * not do it in different places from driver_attach(). - */ - /* Enable interrupts. */ /* For RGMX they are already enabled earlier */ @@ -1801,11 +1795,10 @@ static void octeon_rgmx_init (void *xsc */ link_status.word64 = sc->link_status; - if (link_status.bits.status) { + if (link_status.bits.status) if_link_state_change(sc->ifp, LINK_STATE_UP); - } else { + else if_link_state_change(sc->ifp, LINK_STATE_DOWN); - } RGMX_UNLOCK(sc); }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201003112213.o2BMDHEp087711>