From owner-freebsd-audit Sat Feb 10 21:23:58 2001 Delivered-To: freebsd-audit@freebsd.org Received: from aslan.scsiguy.com (mail.scsiguy.com [63.229.232.106]) by hub.freebsd.org (Postfix) with ESMTP id 78F2037B401 for ; Sat, 10 Feb 2001 21:23:41 -0800 (PST) Received: from scsiguy.com (localhost [127.0.0.1]) by aslan.scsiguy.com (8.11.2/8.9.3) with ESMTP id f1B5NbO10383; Sat, 10 Feb 2001 22:23:38 -0700 (MST) (envelope-from gibbs@scsiguy.com) Message-Id: <200102110523.f1B5NbO10383@aslan.scsiguy.com> X-Mailer: exmh version 2.2 06/23/2000 with nmh-1.0.4 To: mjacob@feral.com Cc: audit@freebsd.org, "Kenneth D. Merry" , Gerard Roudier Subject: Re: a couple of minor but important changes to SCSI error handling In-Reply-To: Your message of "Sat, 10 Feb 2001 18:05:03 PST." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 10 Feb 2001 22:23:37 -0700 From: "Justin T. Gibbs" Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > >First is scsi_all.c: This looks fine. I also verified that the new error recovery code that Ken is reviewing right now also gets this right. >Second is scsi_da.c: ... >10 retries with a .5 second delay between each is still only 5 seconds. 10 >retries might be more appropriate to a SAN environment with at least a couple >of seconds of different initiators spasming the loop. Depending on the error, I don't know that we would necessarily delay or not here. If an initiator is spamming the loop, what does the peripheral driver see? A command timeout? Something reported as a "selection timeout"? If you can be more specific, perhaps we can make the da error handler smarter so that certain types of errors get additional retries (similar perhaps to how we do a series of TURs for some errors in cam_periph_error()). -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message