From owner-freebsd-current@FreeBSD.ORG Wed Jan 5 14:11:53 2011 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50121106566C; Wed, 5 Jan 2011 14:11:53 +0000 (UTC) (envelope-from erik@cederstrand.dk) Received: from csmtp1.one.com (csmtp1.one.com [195.47.247.21]) by mx1.freebsd.org (Postfix) with ESMTP id D89088FC17; Wed, 5 Jan 2011 14:11:52 +0000 (UTC) Received: from [192.168.0.46] (0x573fa596.cpe.ge-1-1-0-1109.ronqu1.customer.tele.dk [87.63.165.150]) by csmtp1.one.com (Postfix) with ESMTP id 95C6D1BC00A25; Wed, 5 Jan 2011 14:11:51 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: multipart/signed; boundary=Apple-Mail-108-249414753; protocol="application/pkcs7-signature"; micalg=sha1 From: Erik Cederstrand In-Reply-To: <4184C8F2-3C6D-46FB-8F10-DDEBA6DB1C35@cederstrand.dk> Date: Wed, 5 Jan 2011 15:11:50 +0100 Message-Id: References: <20110105131439.GN23329@acme.spoerlein.net> <4184C8F2-3C6D-46FB-8F10-DDEBA6DB1C35@cederstrand.dk> To: =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= X-Mailer: Apple Mail (2.1082) X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: current@FreeBSD.org Subject: Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/ X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2011 14:11:53 -0000 --Apple-Mail-108-249414753 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Den 05/01/2011 kl. 14.56 skrev Erik Cederstrand: > Ignoring contrib code for the moment, I decided to look at usr.sbin.pw = from 2011-01-05. There's one report = (http://scan.freebsd.your.org/freebsd-head/usr.sbin.pw/2011-01-05-amd64/re= port-KkilQ3.html#EndPath) which turns out to be a false positive: >=20 > * Step 6 calls cmdhelp() on line 168; > * cmdhelp() ends with "exit(EXIT_FAILURE);" on line 432 which I assume = is exit(3) from libc > * The analyzer doesn't know that this function never returns and = continues to flag a null dereference in step 8 The same is true of err(), verr(), errc(), verrc(), errx(), and verrx() = which is also causing false positive reports. They ultimately call = exit(3). Erik= --Apple-Mail-108-249414753--