Date: Sun, 09 Feb 2014 14:52:54 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Emanuel Haupt <ehaupt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r343457 - head/audio/p5-Shout Message-ID: <EC011389057E119CB2996C3C@atuin.in.mat.cc> In-Reply-To: <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org> References: <201402091101.s19B1aPh072112@svn.freebsd.org> <1E1640591FF296C66F82EF62@atuin.in.mat.cc> <20140209131626.ad5097b391ebb1e6d738e28a@FreeBSD.org> <D51FCA4F34828A264C471DCA@atuin.in.mat.cc> <20140209143756.c1bc46e172d5d5c8979787fc@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 9 f=C3=A9vrier 2014 14:37:56 +0100 Emanuel Haupt <ehaupt@FreeBSD.org> wrote: |> Yes, and like the wiki[1] says, unless there's a tremendous number of |> files and the IO hit is pretty severe you should install them always. |=20 | So you agree with me that the inclusion is required? Nope, the opposite. The wiki says: "The DOCS/EXAMPLES .if blocks can be made unconditional, except in cases when installed files are big enough to cause significant I/O overhead."=20 In that case, you should have removed the conditional install of the files, so that they always get staged, and save make of having to parse bsd.port.mk twice :-) |> (Also, if those are examples, they should go in EXAMPLESDIR) |=20 | I was simply looking at the aspect of converting the port to support | staging. I don't know if the application requires the files to be | installed in EXAMPLESDIR or DOCSDIR. If they're manually installed by the port, that is, not needed, and they're called example* you can safely assume that they're examples, and thus, need to go into the examples directory :-) --=20 Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EC011389057E119CB2996C3C>