Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 May 2003 17:43:32 +0200
From:      Thomas Zenker <thz@Lennartz-electronic.de>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   kern/52725: [PATCH] installincludes for kmods
Message-ID:  <20030527174332.A66018@mezcal.tue.le>
Resent-Message-ID: <200305271550.h4RFoGBZ022649@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         52725
>Category:       kern
>Synopsis:       [PATCH] installincludes for kmods
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue May 27 08:50:16 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     Thomas Zenker
>Release:        FreeBSD 4.8-RC i386
>Organization:
Lennartz electronic
>Environment:
System: FreeBSD mezcal.tue.le 4.8-RC FreeBSD 4.8-RC #31: Tue Mar 11 11:26:15 CET 2003 thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL i386

	stable, current

>Description:
	For kernel modules the ability in the make system to install
	include files via the INCS variable (and brothers) and
	installincludes target is not implemented, as it is for
	prog and lib subdirectories.  The problem is actually, that
	<bsd.incs.mk> is not included in sys/conf/kmod.mk

>How-To-Repeat:
	KMOD = abc
	SRCS = abc.c
	INCS = abc.h
	"make installincludes" does nothing.
	"make install" installs kmod abc.ko, but not include file abc.h.

>Fix:

cvs server: Diffing sys/conf
Index: sys/conf/kmod.mk
===================================================================
RCS file: /usr/cvs/FreeBSD/src/sys/conf/kmod.mk,v
retrieving revision 1.82.2.15
diff -u -r1.82.2.15 kmod.mk
--- sys/conf/kmod.mk	10 Feb 2003 13:11:50 -0000	1.82.2.15
+++ sys/conf/kmod.mk	8 Apr 2003 10:07:27 -0000
@@ -187,6 +187,7 @@
 	    ${_INSTALLFLAGS} ${PROG} ${DESTDIR}${KMODDIR}
 .endif !target(realinstall)
 
+.include <bsd.incs.mk>
 .include <bsd.links.mk>
 
 .if !defined(NOMAN)



-- Thomas Zenker
   c/o Lennartz electronic GmbH
   Bismarckstrasse 136, D-72072 Tuebingen, Germany
   Phone:  +49-(0)7071-93550
   Email:  thz@lennartz-electronic.de
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030527174332.A66018>