From owner-freebsd-current@FreeBSD.ORG Thu Dec 9 15:09:55 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 65AE7106566C; Thu, 9 Dec 2010 15:09:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 373678FC0C; Thu, 9 Dec 2010 15:09:55 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id CC5D246B03; Thu, 9 Dec 2010 10:09:54 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id BC6858A01D; Thu, 9 Dec 2010 10:09:53 -0500 (EST) From: John Baldwin To: freebsd-current@freebsd.org Date: Thu, 9 Dec 2010 10:01:32 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <4D00CDCE.8040509@gthcfoundation.org> <20101209131502.GM33073@deviant.kiev.zoral.com.ua> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012091001.32727.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 09 Dec 2010 10:09:53 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: Kostik Belousov , Etienne Robillard , Giorgos Keramidas Subject: Re: shared lib issue in /usr/obj? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2010 15:09:55 -0000 On Thursday, December 09, 2010 8:52:06 am Giorgos Keramidas wrote: > On Thu, 9 Dec 2010 15:15:02 +0200, Kostik Belousov wrote: > > On Thu, Dec 09, 2010 at 01:57:16PM +0100, Giorgos Keramidas wrote: > >> They are installed with "make install" and when you run "make install" > >> with PRECIOUSLIB defined, bsd.lib.mk adds this to SHINSTALLFLAGS: > >> > >> .if defined(PRECIOUSLIB) > >> .if !defined(NO_FSCHG) > >> SHLINSTALLFLAGS+= -fschg > >> .endif > >> SHLINSTALLFLAGS+= -S > >> .endif > >> > >> The Makefiles that set PRECIOUSLIB today are: > >> > >> keramida@bokos:/usr/src$ grep -r 'PRECIOUSLIB.*=' * > >> lib/libc/Makefile:PRECIOUSLIB= > >> lib/libcrypt/Makefile:PRECIOUSLIB= > >> lib/libkse/Makefile:PRECIOUSLIB= > >> lib/librt/Makefile:PRECIOUSLIB= > >> lib/libthr/Makefile:PRECIOUSLIB= > >> keramida@bokos:/usr/src$ > > > > Would be nice if lib32 installation into the obj/ area somehow > > eliminated the setting of schg flag. There is no reason to have schg > > set on files in obj. > > Yes, that's a good idea. > > I don't have root access to an amd64 system to test this now, but I > think all we need to change is: > > %%% > $ hg diff . > diff -r e52d3f3de04d Makefile.inc1 > --- a/Makefile.inc1 Thu Dec 09 12:35:12 2010 +0100 > +++ b/Makefile.inc1 Thu Dec 09 14:50:06 2010 +0100 > @@ -318,7 +318,8 @@ LIB32WMAKEENV+= MAKEOBJDIRPREFIX=${OBJTR > CXX="${CXX} ${LIB32FLAGS}" \ > OBJC="${OBJC} ${LIB32FLAGS}" \ > LIBDIR=/usr/lib32 \ > - SHLIBDIR=/usr/lib32 > + SHLIBDIR=/usr/lib32 \ > + NO_FSCHG='' > > LIB32WMAKE= ${LIB32WMAKEENV} ${MAKE} -DNO_CPU_CFLAGS -DCOMPAT_32BIT \ > -DWITHOUT_BIND -DWITHOUT_MAN -DWITHOUT_INFO \ > $ > %%% > > This should strip the -fschg option from lib32's installation commands. Does that affect the installed versions of the libraries in /usr/lib32? Those should probably have schg set. -- John Baldwin