From owner-freebsd-arm@FreeBSD.ORG Tue Nov 25 18:36:28 2008 Return-Path: Delivered-To: arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E6A491065675; Tue, 25 Nov 2008 18:36:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id AB14F8FC22; Tue, 25 Nov 2008 18:36:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id mAPIZIHp061459; Tue, 25 Nov 2008 11:35:18 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Tue, 25 Nov 2008 11:36:47 -0700 (MST) Message-Id: <20081125.113647.1346821827.imp@bsdimp.com> To: stas@freebsd.org From: "M. Warner Losh" In-Reply-To: <20081125212409.3dab8178.stas@FreeBSD.org> References: <20081125.104452.535842403.imp@bsdimp.com> <20081125212409.3dab8178.stas@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arm@freebsd.org Subject: Re: Code review request: boards on AT91 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 18:36:29 -0000 In message: <20081125212409.3dab8178.stas@FreeBSD.org> Stanislav Sedov writes: : -----BEGIN PGP SIGNED MESSAGE----- : Hash: SHA1 : : On Tue, 25 Nov 2008 10:44:52 -0700 (MST) : "M. Warner Losh" mentioned: : : > I'm trying a little experiment. I'm moving the board support for the : > different sets of boards we support to their own file. This is the : > first step in moving to supporting multiple boards more easily. : > There's a number of gross hacks to make this work now in at91 land, : > and I'd like to clean them up. The mv port is much cleaner, but we : > still likely need some way to identify boards and get the right board : > support code called. In Linux land, all ARM boot loaders are expected : > to pass in a machine type, which is used to do the multiplexing. : > Something similar in FreeBSD would be useful (and not just for ARM). : > : > Eventually, I'd like to see more common code between the different arm : > variants. This will ease porting efforts as well as make the code : > more robust. : : I think we could pass the board type via a special kenv variable : for now. I think it will work fine and applicable to all supported : architectures. We could probably reuse board type constants that Linux : kernel uses. Right now that's passed in from uboot and other loaders in I think r3, but I'd have to go look at some other code to be sure. : > If anybody wants me to write up where I'm going with this, or answer : > any question, please feel free to ask. Also, comments would be nice. : > : > Warner : > : : The code looks OK to me. I have only one question: why you have added : a commented out AT91_BOARD_KB920X option to the default kernel config? : Is it just a leftover? Leftover. Forgot the basics of kernel config for a moment. Warner : - -- : Stanislav Sedov : ST4096-RIPE : -----BEGIN PGP SIGNATURE----- : : iEYEARECAAYFAkksQs0ACgkQK/VZk+smlYFntwCfbHv6JJmTjzI6GL5Ra1k4nA2a : nGAAn06uoskVCyZ2E5eFkTtQQ7eXnmz0 : =xuFv : -----END PGP SIGNATURE----- : :