From owner-svn-src-all@freebsd.org  Sat Mar  4 13:01:37 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37AFACF935C;
 Sat,  4 Mar 2017 13:01:37 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140])
 by mx1.freebsd.org (Postfix) with ESMTP id 1B2D11A3C;
 Sat,  4 Mar 2017 13:01:35 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
 [212.40.38.100])
 by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA01048;
 Sat, 04 Mar 2017 15:01:33 +0200 (EET) (envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
 by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
 id 1ck9JV-000Bsl-Bt; Sat, 04 Mar 2017 15:01:33 +0200
Subject: Re: svn commit: r314666 - head/sys/dev/ioat
To: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
 svn-src-head@FreeBSD.org
References: <201703041251.v24Cpv6D068349@repo.freebsd.org>
From: Andriy Gapon <avg@FreeBSD.org>
Message-ID: <07435c71-c634-fd88-7281-d9e0a8e7eecf@FreeBSD.org>
Date: Sat, 4 Mar 2017 15:00:37 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <201703041251.v24Cpv6D068349@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Mar 2017 13:01:37 -0000

On 04/03/2017 14:51, Andriy Gapon wrote:
> Author: avg
> Date: Sat Mar  4 12:51:57 2017
> New Revision: 314666
> URL: https://svnweb.freebsd.org/changeset/base/314666
> 
> Log:
>   ioat: don't specify inline for function with variable argument list
>   
>   Modern GCC and Clang simply ignore the qualifier, while the old base GCC
>   produces a warning (treated as an error in the kernel build).

Just in case, here is the exact error that I see:
ioat_test.c:593: warning: function '_ioat_test_log' can never be inlined because
it uses variable argument lists [-Winline]

>   Approved by:	cem
>   MFC after:	5 days
> 
> Modified:
>   head/sys/dev/ioat/ioat_test.c
> 
> Modified: head/sys/dev/ioat/ioat_test.c
> ==============================================================================
> --- head/sys/dev/ioat/ioat_test.c	Sat Mar  4 12:42:52 2017	(r314665)
> +++ head/sys/dev/ioat/ioat_test.c	Sat Mar  4 12:51:57 2017	(r314666)
> @@ -79,7 +79,7 @@ static int g_thread_index = 1;
>  static struct cdev *g_ioat_cdev = NULL;
>  
>  #define	ioat_test_log(v, ...)	_ioat_test_log((v), "ioat_test: " __VA_ARGS__)
> -static inline void _ioat_test_log(int verbosity, const char *fmt, ...);
> +static void _ioat_test_log(int verbosity, const char *fmt, ...);
>  
>  static void
>  ioat_test_transaction_destroy(struct test_transaction *tx)
> @@ -579,7 +579,7 @@ ioat_test_detach(void)
>  	mtx_unlock(&Giant);
>  }
>  
> -static inline void
> +static void
>  _ioat_test_log(int verbosity, const char *fmt, ...)
>  {
>  	va_list argp;
> 


-- 
Andriy Gapon