From owner-trustedbsd-audit@freebsd.org Tue Dec 18 16:25:06 2018 Return-Path: Delivered-To: trustedbsd-audit@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 062B31336185 for ; Tue, 18 Dec 2018 16:25:06 +0000 (UTC) (envelope-from jack@gandi.net) Received: from gandi.net (mail12.gandi.net [217.70.182.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9DE9A7486E; Tue, 18 Dec 2018 16:25:05 +0000 (UTC) (envelope-from jack@gandi.net) Received: from thinkpad-gandi (tgordon.gandi.net [217.70.181.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gandi.net (Postfix) with ESMTPS id 52CC3160347; Tue, 18 Dec 2018 16:24:58 +0000 (UTC) Date: Tue, 18 Dec 2018 17:24:58 +0100 From: Jack Halford To: "Robert N. M. Watson" Cc: trustedbsd-audit@freebsd.org Subject: Re: Re: new syscalls audit events Message-ID: <20181218162458.m36gxcrimwri3ttz@thinkpad-gandi> References: <20181214161615.lvk2gsqtf7gij4fc@thinkpad-gandi> <8BA9D408-41F8-4E59-8AA9-39740A2F65C5@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <8BA9D408-41F8-4E59-8AA9-39740A2F65C5@FreeBSD.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 9DE9A7486E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.986,0] X-Mailman-Approved-At: Tue, 18 Dec 2018 19:14:23 +0000 X-BeenThere: trustedbsd-audit@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: TrustedBSD Audit Discussion List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 16:25:06 -0000 >> - contrib/openbsm/etc/audit_event >> - contrib/openbsm/sys/bsm/audit_kevents.h >> - sys/bsm/audit_kevents.h > >These changes will need to be upstreamed to OpenBSM in GitHub. As there might be conflicting new events using the same numbers, do use the numbers assigned by OpenBSM rather than those that might appear most obvious in FreeBSD, as BSM is used across several operating systems, and we require consistent event-number assignment. > >> - sys/kern/syscalls.master >> - sys/compat/freebsd32/syscalls.master > >You will also need to modify sys/security/audit_bsm_klib.c to generate BSM records and encode arguments/return values/etc. Thanks for the reply, I'll look into upstreaming all this to github before my review then. Likely after the holidays. -- Jack