Date: Fri, 18 Jan 2013 15:49:54 +0200 From: Vitalij Satanivskij <satan@ukr.net> To: Vitalij Satanivskij <satan@ukr.net> Cc: Jaakko Heinonen <jh@FreeBSD.org>, Alexander Motin <mav@FreeBSD.org>, Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: panic after r244584 Message-ID: <20130118134954.GA7848@hell.ukr.net> In-Reply-To: <20130118133415.GA7189@hell.ukr.net> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <20130118133415.GA7189@hell.ukr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
May be just do sanitizing for elmpriv->descr? something like change whitespace to "_" or just delete it? Vitalij Satanivskij wrote: VS> Jaakko Heinonen wrote: VS> JH> On 2013-01-18, Alexander Motin wrote: VS> JH> > > AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) VS> JH> VS> JH> > > AM> The panic is triggered by the check added by the recent r244584 change. VS> JH> > > AM> The space in device name came from the enclosure device, and I guess it VS> JH> > > AM> may be quite often situation. Using human readable name supposed to help VS> JH> > > AM> system administrators, but with spaces banned that may be a problem. VS> JH> > > VS> JH> > > That's was not created by human, it was generated (I think so) by system. VS> JH> > VS> JH> > These strings are flashed into enclosure firmware by manufacturer. VS> JH> VS> JH> You can't rely on that any string can be safely used as a device name VS> JH> even if spaces were allowed. Consider for example duplicate names and VS> JH> "../". VS> JH> VS> JH> Where these names are generated? The original report didn't contain a VS> JH> backtrace. VS> VS> Yes. No backtrace, because of switching off all debuging in kernel. VS> VS> For now I can't use that's server for testing, but there are another servers waiting for upgrade. VS> VS> I will try to reproduce problem with kernel debuger enabled. VS> VS> VS> _______________________________________________ VS> freebsd-current@freebsd.org mailing list VS> http://lists.freebsd.org/mailman/listinfo/freebsd-current VS> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130118134954.GA7848>