Date: Sun, 14 Jun 2015 12:19:36 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Adrian Chadd <adrian@freebsd.org> Cc: Bruce Simpson <bms@fastmail.net>, Steve Kargl <sgk@troutmask.apl.washington.edu>, Slawa Olhovchenkov <slw@zxy.spb.ru>, Craig Rodrigues <rodrigc@freebsd.org>, Marcel Moolenaar <marcel@xcllnt.net>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Marcel Moolenaar <marcel@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r284198 - head/bin/ls Message-ID: <E5005B17-C45A-4EDD-80F3-E671FA428310@gmail.com> In-Reply-To: <CAJ-VmomyoF=egqDD-R%2Biun-LtRhrGK3p8%2BSrd5uzC6gGHQmMDg@mail.gmail.com> References: <201506100127.t5A1RdX6051959@svn.freebsd.org> <20150612204309.11dd3391@kan> <20150613024916.GA98218@troutmask.apl.washington.edu> <1434208622.1415.57.camel@freebsd.org> <C88CB169-12FE-4692-92AA-5C7D41BB61DF@FreeBSD.org> <557C661F.8080104@freebsd.org> <860017ED-D754-450C-865D-2D81A30C2212@xcllnt.net> <CAG=rPVd93Q18aYnSGSf_QH4C08RCq5wsdKQSNYTgWQ2huTbUHQ@mail.gmail.com> <20150614100045.GF58397@zxy.spb.ru> <557D55CB.5050009@fastmail.net> <20150614171031.GA5857@troutmask.apl.washington.edu> <557DCBED.2010804@fastmail.net> <CAJ-VmoktZTMnva02rTojZeGcd3q5BJ9RHGUHgFA=Ghn=WOxQyw@mail.gmail.com> <887CD9C6-9807-48AF-A7A6-B33F91901414@gmail.com> <CAJ-VmomyoF=egqDD-R%2Biun-LtRhrGK3p8%2BSrd5uzC6gGHQmMDg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jun 14, 2015, at 12:07, Adrian Chadd <adrian@freebsd.org> wrote:
>=20
>> On 14 June 2015 at 12:02, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>>=20
>>> On Jun 14, 2015, at 11:53, Adrian Chadd <adrian@freebsd.org> wrote:
>>>=20
>>> We have busybox already - it's called bsdbox, and it's in base, and
>>> we're already using it, and yes, it does pull in libxo. :)
>>>=20
>>> I'm not worried about the size increase of libxo. That's the wrong
>>> thing to focus on. If it gets much more bloated then I'll poke people
>>> with the big "what are you thinking" stick. The issues people have
>>> aren't size related, they're "this API needs improvement and we have
>>> bugs introduced into tools."
>>>=20
>>> I do like how zero percent of the comments are "hey, maybe we need
>>> unit tests that run these tools and ensure they output the right
>>> stuff." If this were ${WORK} and I were ${BOSS}, I'd have asked the
>>> libxo developers to include unit tests before/after for each thing
>>> they broke, so we don't have a repeat of this kind of thing. But, this
>>> apparently isn't ${WORK} and I definitely don't want to be anyones
>>> boss, so..
>>=20
>> Ugh. I'll write the tests ;(...
>=20
> I'm not your boss!
>=20
> (but if you go and do it - great! thankyou! This is what should've
> been neckbearded, not the rest of the thread!)
A part of it, yeah.. Not having manpqges still makes it annoying when I have=
to figure out how things work ;(.
Next time someone else converts ANYTHING to libxo -- write tests FIRST to ma=
ke sure you're not breaking legacy behavior. If you need help figuring out h=
ow to do that, I'll be more than happy to document it on a wiki page, with s=
imple, concise directions.
Thanks!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E5005B17-C45A-4EDD-80F3-E671FA428310>