From owner-svn-ports-head@freebsd.org Mon Oct 5 01:54:52 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9501A10016; Mon, 5 Oct 2015 01:54:52 +0000 (UTC) (envelope-from linpct@gmail.com) Received: from mail-qg0-x22b.google.com (mail-qg0-x22b.google.com [IPv6:2607:f8b0:400d:c04::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A681A11A4; Mon, 5 Oct 2015 01:54:52 +0000 (UTC) (envelope-from linpct@gmail.com) Received: by qgez77 with SMTP id z77so138051489qge.1; Sun, 04 Oct 2015 18:54:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=c2nSc0t22uT9QlGD5iC8TiA8EGGlDN6vNjM8WRXd8Ro=; b=Df0Go5mnikXVOqvfQISV9BGlQWA1MDPCKFNpygeRpGhJco1+VwVpxA7LxWtETMzNye GHhp9BV9iO4CaWRMGzpncoHE3SwP9fgv81KUPow4hmmhku10mzIlyySJAH009FJD6SEa nry1G7+KoVJGOyUlpyR7YEoK1MNS3Zt1JJIsZE9pZltc8lEhn9vU+8ThrJyYUadKZiNK pD8Xg4UVVSRKhmygSeENWQ2DhhNurLuvETgLTtYxENzonXBErhuxtmjGocQcWINg9F0I CqIEvUIaU1pO0KpQdBNM2aCzfFZ4/ATusH+TXxV3KJylVim6tmJdKiBcapp6mQnaLfIH zWtg== MIME-Version: 1.0 X-Received: by 10.140.98.213 with SMTP id o79mr34588612qge.19.1444010091572; Sun, 04 Oct 2015 18:54:51 -0700 (PDT) Received: by 10.140.98.134 with HTTP; Sun, 4 Oct 2015 18:54:51 -0700 (PDT) In-Reply-To: References: <201510011746.t91HkPee014858@repo.freebsd.org> Date: Mon, 5 Oct 2015 09:54:51 +0800 Message-ID: Subject: Re: svn commit: r398375 - head/www/node From: Daniel Lin To: Gerald Pfeifer Cc: Kurt Jaeger , fcharlier@ploup.net, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2015 01:54:53 -0000 Hi, I have no idea if FreeBSD 9.3 using GCC 4.8 as the minimum version. But if so, I agree USE_GCC= yes Thanks. 2015-10-05 7:51 GMT+08:00 Gerald Pfeifer : > On Thu, 1 Oct 2015, Kurt Jaeger wrote: > > Log: > > www/node: fix build on 9.3 > > > > - enforce dependency on gcc48 on 9.3 > > > > PR: 203307 > > Submitted by: fcharlier@ploup.net > > Approved by: linpct@gmail.com (maintainer) > > > > Modified: head/www/node/Makefile > > > ============================================================================== > > --- head/www/node/Makefile Thu Oct 1 17:31:33 2015 (r398374) > > +++ head/www/node/Makefile Thu Oct 1 17:46:24 2015 (r398375) > > @@ -39,7 +39,7 @@ CFLAGS+= -Wno-unused-const-variable > > .endif > > .else > > MAKE_ARGS+= strictaliasing=off > > -USE_GCC= any > > +USE_GCC= 4.8+ > > .endif > > I suggest to make this USE_GCC=yes instead (which currently already > has GCC 4.8 as the minimum version). > > If you agree, I can make this change. > > Gerald > -- Daniel Lin (pct)