From owner-freebsd-current  Tue Aug 21 17:56:46 2001
Delivered-To: freebsd-current@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP id 787BF37B40E
	for <freebsd-current@FreeBSD.ORG>; Tue, 21 Aug 2001 17:56:42 -0700 (PDT)
	(envelope-from iedowse@maths.tcd.ie)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa44790@salmon>; 22 Aug 2001 01:56:41 +0100 (BST)
To: Ollivier Robert <roberto@keltia.freenix.fr>
Cc: FreeBSD Current Users' list <freebsd-current@FreeBSD.ORG>
Subject: Re: Panic with latest current/UFS_DIRHASH 
In-Reply-To: Your message of "Tue, 21 Aug 2001 17:15:10 +0200."
             <20010821171510.A75116@tara.freenix.org> 
Date: Wed, 22 Aug 2001 01:56:41 +0100
From: Ian Dowse <iedowse@maths.tcd.ie>
Message-ID:  <200108220156.aa44790@salmon.maths.tcd.ie>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

In message <20010821171510.A75116@tara.freenix.org>, Ollivier Robert writes:
>According to Ollivier Robert:
>> Just upgraded my laptop to the latest current and during installworld, got
>> this panic:
>> 
>> panic: ufsdirhash_findslot: 'ka_JP.Shift_JIS' not found

Thanks for the bug report - see my other mail to -current for
further details, but the quick answer is that dirhash has a bug
that is triggered by the odd directory entries that fsck sometimes
leaves behind. This short patch should fix it:

Ian

Index: ufs_lookup.c
===================================================================
RCS file: /FreeBSD/FreeBSD-CVS/src/sys/ufs/ufs/ufs_lookup.c,v
retrieving revision 1.52
diff -u -r1.52 ufs_lookup.c
--- ufs_lookup.c	2001/08/18 03:08:48	1.52
+++ ufs_lookup.c	2001/08/22 00:27:17
@@ -884,7 +884,7 @@
 		dsize = DIRSIZ(OFSFMT(dvp), nep);
 		spacefree += nep->d_reclen - dsize;
 #ifdef UFS_DIRHASH
-		if (dp->i_dirhash != NULL)
+		if (dp->i_dirhash != NULL && nep->d_ino)
 			ufsdirhash_move(dp, nep, dp->i_offset + loc,
 			    dp->i_offset + ((char *)ep - dirbuf));
 #endif



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message