From owner-svn-src-all@FreeBSD.ORG Mon May 18 16:41:09 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 97FD9813; Mon, 18 May 2015 16:41:09 +0000 (UTC) Received: from mail-pd0-x235.google.com (mail-pd0-x235.google.com [IPv6:2607:f8b0:400e:c02::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 645E81198; Mon, 18 May 2015 16:41:09 +0000 (UTC) Received: by pdbqa5 with SMTP id qa5so156239717pdb.0; Mon, 18 May 2015 09:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:mime-version:in-reply-to:content-type :content-transfer-encoding:message-id:cc:from:subject:date:to; bh=lzJUkatJM+PXmp91jTyMvtXdRBILUh4cWyAJZGlzbEg=; b=WD8/8vzu1x/y+Rlj7lq2AXdziNmST0gKTzZUUKnwE1iVtuXGB7Ld81K+r9BCRFATy/ JLKL5OilBuRNIvVdl5rGHqmXf41XL739US8OJry6guObuX3J8hxVJc/DReV7zsZ4FtSr mxzQuRD9B/dmswvIfTxLhw2b108cWD+3rxMX1lWEKXIIJw50iGiTrS7GamRGJzj14yZb f5w3Ih8W6ABnIKFp/W3O98rm2gXn5SH5t0MjdgZArXcAIEAnBZfF0oG289pEYlXtw9fy 92a1OhcPBKU44MTrsPIXpJiyDndzmw9Ov8OuHmHdEz7izU6X0tO7te/YHk5JR6o1ZTBE 6hTw== X-Received: by 10.70.51.67 with SMTP id i3mr45808886pdo.145.1431967268736; Mon, 18 May 2015 09:41:08 -0700 (PDT) Received: from ?IPv6:2601:8:ab80:7d6:87a:83fd:2a24:1b9d? ([2601:8:ab80:7d6:87a:83fd:2a24:1b9d]) by mx.google.com with ESMTPSA id xz3sm10542631pbc.13.2015.05.18.09.41.07 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 May 2015 09:41:07 -0700 (PDT) References: <201505151825.t4FIPnxJ099637@svn.freebsd.org> <059F2C65-F92D-445C-B603-0FAE0CAF976D@gmail.com> <1431877581.91685.49.camel@freebsd.org> <7F73A915E7DF0EE8DC6149EC@atuin.in.mat.cc> <1431957864.91685.57.camel@freebsd.org> Mime-Version: 1.0 (1.0) In-Reply-To: <1431957864.91685.57.camel@freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: Cc: Mathieu Arnold , Eitan Adler , "phabric-admin@freebsd.org" , Adrian Chadd , Zbigniew Bodek , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Mailer: iPhone Mail (12F70) From: Garrett Cooper Subject: Re: svn commit: r282985 - in head/sys: arm/annapurna arm/annapurna/alpine arm/annapurna/alpine/hal arm/conf boot/fdt/dts/arm Date: Mon, 18 May 2015 09:41:06 -0700 To: Ian Lepore X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 16:41:09 -0000 > On May 18, 2015, at 07:04, Ian Lepore wrote: > >> On Mon, 2015-05-18 at 10:14 +0200, Mathieu Arnold wrote: >> +--On 18 mai 2015 00:21:43 -0700 Eitan Adler wrote: >> | On 17 May 2015 at 08:46, Ian Lepore wrote: >> |> On Sat, 2015-05-16 at 21:04 -0700, Garrett Cooper wrote: >> |>> > On May 16, 2015, at 18:45, Adrian Chadd wrote: >> |>> > >> |>> > Did you commit files with DOS newlines in them? :) >> |>> > >> |>> > tsk tsk tsk tsk tsk. I think should fix that.. >> |>> >> |>> Better yet it should probably be disabled in svn... >> |>> >> |> >> |> Or flagged by some filter as a diff is uploaded to phabricator, since >> |> the web display obscures whitespace. >> | >> | This is possible. Would blocking all diffs that match /\r\n$/ work? >> >> That would crap up all patches that match that, which is a bad idea. > > Why would that be a bad idea? Do we have files in the system that > legitimately end with MSDOS line endings that need to be preserved as > such? > > I'm not sure blocking is the right thing anyway, it would be better if > it was like a warning dialog..."The diff you just uploaded contains DOS > line endings, continue?" There are some files in contrib/ with CRLF endings iirc... Thanks!