From owner-cvs-all@FreeBSD.ORG  Mon Oct 11 19:02:38 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id F06CC16A4CE; Mon, 11 Oct 2004 19:02:37 +0000 (GMT)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.13.1/8.13.1) with ESMTP id i9BJ2bC9053059;
	Mon, 11 Oct 2004 15:02:37 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.13.1/8.13.1/Submit) id i9BJ2bQ2053058;
	Mon, 11 Oct 2004 15:02:37 -0400 (EDT)
	(envelope-from green)
Date: Mon, 11 Oct 2004 15:02:37 -0400
From: Brian Fundakowski Feldman <green@FreeBSD.org>
To: Robert Watson <rwatson@FreeBSD.org>
Message-ID: <20041011190237.GI988@green.homeunix.org>
References: <200410090816.i998Gbs5076009@repoman.freebsd.org>
	<Pine.NEB.3.96L.1041009053042.93055E-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.NEB.3.96L.1041009053042.93055E-100000@fledge.watson.org>
User-Agent: Mutt/1.5.6i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_witness.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Oct 2004 19:02:38 -0000

On Sat, Oct 09, 2004 at 05:31:30AM -0400, Robert Watson wrote:
> On Sat, 9 Oct 2004, Brian Feldman wrote:
> 
> > green       2004-10-09 08:16:37 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             subr_witness.c 
> >   Log:
> >   Don't "implicitly order all sleep locks before spin locks" in witness
> >   when the spin lock in question isn't -- it's the critical_enter() that
> >   KDB set.  No more panic in DDB for console -> syscons -> tty -> knote
> >   operations.
> 
> I don't have an opinion on whether this is a good change, but I will say
> that the bug you're seeing is a bug in the syscons code, not the result of
> a witness bug.  syscons should not be calling into the tty code from the
> polled I/O interface used by the debugger, and hence should never make it
> to the KQ code.

Could we get whoever broke syscons to fix it?

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\