Date: Mon, 27 Apr 2015 16:56:19 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: "Julian H. Stacey" <jhs@berklix.com>, Baptiste Daroussin <bapt@freebsd.org> Cc: x11@freebsd.org Subject: Re: patch for Message-ID: <553EA273.7020802@FreeBSD.org> In-Reply-To: <201504271832.t3RIUoPA023168@fire.js.berklix.net> References: <201504271832.t3RIUoPA023168@fire.js.berklix.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 04/27/2015 14:30, Julian H. Stacey wrote: > Baptiste Daroussin wrote: >> On Mon, Apr 27, 2015 at 02:55:13PM +0200, Julian H. Stacey >> wrote: >>> Hi x11@freebsd.org, cc: anholt@FreeBSD.org as creator as no >>> MAINTAINER=3D ) =20 I wrote this patch after graphics/dri >>> failed. Comments please ? =20 >>> http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/graphics/dri/Make= >> >>> file.REL=3D10.1-RELEASE.diff >>> =20 *** 10.1-RELEASE/ports/graphics/dri/Makefile Mon Apr 27 >>> 14:34:42 2015 --- new-generic/ports/graphics/dri/Makefile Mon >>> Apr 27 14:36:27 2015 *************** *** 12,17 **** --- 12,25 >>> ---- LIB_DEPENDS=3D libdrm.so:${PORTSDIR}/graphics/libdrm \ >>> libexpat.so:${PORTSDIR}/textproc/expat2 =20 + LIB_DEPENDS+=3D >>> ${PORTSDIR}/textproc/py-libxml2 + # LIB_DEPENDS+=3D >>> lib/python2.7/site-packages/libxml2mod.so:${PORTSDIR}= >> /textproc/py-libxml2 >>> + # To avoid error: + # checking python2 module: libxml2... >>> no + # configure: error: failed to find required module >>> libxml2 + # =3D=3D=3D> Script "configure" failed >>> unexpectedly. + # Please report the problem to >>> x11@FreeBSD.org [maintainer] and att= >> ach the >>> +=20 USES+=3D gettext:build USE_XORG=3D glproto x11 xext >>> xxf86vm xdamage xfixes dri2proto >> >> I removed Eric as he is not working on this, the maintainer is >> x11@ >> >> This patch is wrong the syntax for libdepend is really not the >> proper synta= x. >> >> Btw this is certainly not a build depend you do expect here but a >> BUILD_DEP= ENDS >> >> Best regards, Bapt > > Ah, Yes ! Thanks. So BUILD_DEPENDS+= > ${PORTSDIR}/textproc/py-libxml2 would suffice, but maybe it should > be longer ? maybe similar to BUILD_DEPENDS+= \ > lib/python2.7/site-packages/libxml2mod.so:\ > ${PORTSDIR}/textproc/py-libxml2 I tried to find what that something > should be, by doing cd /usr/ports/textproc/py-libxml2; make clean ; > make deinstall cd /usr/ports/graphics/dri; make clean; make But I > failed to find whatever it was, so not sure if BUILD_DEPENDS is > needed, or if it was just some local aberation here. > > PS Apologies for truncated "Subject: patch for" instead of > "Subject: patch for graphics/dri/Makefile" It looks like your patch is based on a quite old ports tree. In fact, I can't reproduce the problem. Can you please update your ports tree and try again? Jung-uk Kim -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVPqJtAAoJEHyflib82/FGIMIH/2sXwFNPGn9RFJr+mmQEzM93 3pZBP7xJpXqcw3GVnwf02i49eiEN5u+AyAgk3VJ8BQFHLoi3cU8Z/lBoVvUxiC5r CyZRkUJbG+/vQaBXV37pt+sYwWUeIb7094P5ZZTWwGxZ1XxD23y5gR774XOOSBcY x+dTg8jAS1OB4sX9isO3RasOO9TDk+9mFOmZ/MY1+1TWY9wN8jhbgV0VXwLX7nNy rjwf83d/CwYhmB0gwWm9cP+5xnGAbIIqjQDGIFZoEWuqoQO+nPwiHfLQBmGIdicb lHL1NKcoS4KI9WYWE88T/zOCdaSBA3tM+TfnD9d1mg6QT2Ge3UAFFyi9wdiBMg4= =IIzd -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?553EA273.7020802>