Date: Tue, 16 Jan 2018 03:12:44 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 225206] devel/xdg-utils: xdg-mime has bogus patch to use stat -f Message-ID: <bug-225206-6497-63XnLV4y4v@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-225206-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-225206-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
John Hein <z7dr6ut7gs@snkmail.com> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to gnome@FreeBSD.o= rg: Bug 225206: devel/xdg-utils: xdg-mime has bogus patch to use stat -f https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225206 --- Description --- Created attachment 189782 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D189782&action= =3Dedit [patch] remove incorrect stat -f patch in favor of [now] fully supported readlink -f 'stat -f <file>' has never been correct, but now the patch to use it instea= d of readlink -f is unnecessary. readlink -f has worked since freebsd 8, so ust remove the bogus stat -f. I think 'stat -f' was an attempt to work around the absence of '-f' for readlink in freebsd before 8.x. But it's just an invalid invocation of stat that basically winds up doing nothing as used in xdg-mime. It certainly do= es not follow all links to get the filename of the link target. One could file a bug with stat where 'stat -L -F %N <file>' reports the nam= e of a link (if <file> is a sym link) instead of the link target. Maybe that's = what was originally intended as a replacement for readlink -f. But that's a separate bug and such a replacement is no longer needed for xdg-mime.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-225206-6497-63XnLV4y4v>