From owner-freebsd-bluetooth@freebsd.org  Tue Sep 22 20:03:55 2015
Return-Path: <owner-freebsd-bluetooth@freebsd.org>
Delivered-To: freebsd-bluetooth@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A687A9CE516
 for <freebsd-bluetooth@mailman.ysv.freebsd.org>;
 Tue, 22 Sep 2015 20:03:55 +0000 (UTC)
 (envelope-from plunky@ogmig.net)
Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net
 [IPv6:2001:4b98:c:538::197])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 65EEA1D85
 for <freebsd-bluetooth@freebsd.org>; Tue, 22 Sep 2015 20:03:55 +0000 (UTC)
 (envelope-from plunky@ogmig.net)
Received: from mfilter16-d.gandi.net (mfilter16-d.gandi.net [217.70.178.144])
 by relay5-d.mail.gandi.net (Postfix) with ESMTP id ADCC441C067;
 Tue, 22 Sep 2015 22:03:52 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at mfilter16-d.gandi.net
Received: from relay5-d.mail.gandi.net ([IPv6:::ffff:217.70.183.197])
 by mfilter16-d.gandi.net (mfilter16-d.gandi.net [::ffff:10.0.15.180])
 (amavisd-new, port 10024)
 with ESMTP id fAUJ1VA8cjgC; Tue, 22 Sep 2015 22:03:51 +0200 (CEST)
X-Originating-IP: 31.68.69.24
Received: from galant.ogmig.net (unknown [31.68.69.24])
 (Authenticated sender: plunky@ogmig.net)
 by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 3991C41C06A;
 Tue, 22 Sep 2015 22:03:49 +0200 (CEST)
Received: by galant.ogmig.net (Postfix, from userid 1000)
 id A5C0226026A; Tue, 22 Sep 2015 21:03:59 +0100 (BST)
Date: Tue, 22 Sep 2015 21:03:59 +0100 (BST)
From: Iain Hibbert <plunky@ogmig.net>
To: Dirk Engling <erdgeist@erdgeist.org>
cc: "freebsd-bluetooth@freebsd.org" <freebsd-bluetooth@freebsd.org>
Subject: Re: Apple Magic Mouse
In-Reply-To: <55FF08C5.1020509@erdgeist.org>
Message-ID: <alpine.NEB.2.11.1509222049120.329@galant.ogmig.net>
References: <1437909200.57929.3.camel@yandex.com>
 <alpine.NEB.2.11.1508092034290.5638@galant.ogmig.net>
 <55F4362A.4050203@erdgeist.org>
 <CAFPOs6p+EZDctPodY6DBbnhfZQFz+o0uKSRvvqQBcM1QL3ACXw@mail.gmail.com>
 <55F60ED8.8080203@erdgeist.org>
 <alpine.NEB.2.11.1509141802300.690@galant.ogmig.net>
 <55F78EB8.8060408@erdgeist.org> <55FCDBB6.6090004@erdgeist.org>
 <55FF08C5.1020509@erdgeist.org>
User-Agent: Alpine 2.11 (NEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-BeenThere: freebsd-bluetooth@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Using Bluetooth in FreeBSD environments
 <freebsd-bluetooth.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bluetooth>, 
 <mailto:freebsd-bluetooth-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bluetooth/>
List-Post: <mailto:freebsd-bluetooth@freebsd.org>
List-Help: <mailto:freebsd-bluetooth-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bluetooth>, 
 <mailto:freebsd-bluetooth-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2015 20:03:55 -0000

On Sun, 20 Sep 2015, Dirk Engling wrote:

> > Feedback is welcome.

+/*
+ * Hard coded attibute IDs taken from the
+ * DEVICE IDENTIFICATION PROFILE SPECIFICATION V13 p.12
+ */
+
+#define SDP_DEVICE_ID_SERVICE_ATTR_VENDORID  0x0201
+#define SDP_DEVICE_ID_SERVICE_ATTR_PRODUCTID 0x0202
+#define SDP_DEVICE_ID_SERVICE_ATTR_VERSION   0x0203
+#define SDP_DEVICE_ID_RANGE SDP_ATTR_RANGE( \
+ SDP_DEVICE_ID_SERVICE_ATTR_VENDORID, SDP_DEVICE_ID_SERVICE_ATTR_VERSION )

in the rest of SDP code, these are styled SDP_ATTR_* is there a reason to 
be different?

 /*
+ * Inoffical and unannounced report ids for Apple Mice and trackpad
+ */

it is not required to credit the source of the information used to write 
the handler for this device, but it is good practice to do so :)

iain