From owner-freebsd-ports@FreeBSD.ORG Sun Jan 23 16:36:04 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F9031065672 for ; Sun, 23 Jan 2011 16:36:04 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 8E32C8FC14 for ; Sun, 23 Jan 2011 16:36:03 +0000 (UTC) Received: by bwz12 with SMTP id 12so3052678bwz.13 for ; Sun, 23 Jan 2011 08:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=N2gY6tNWj8A9A4e8SW69/tWVlB1v9io9wir0zL4YHyA=; b=mCKbGneD4JlUtsIK1v0NPiw9ad5vDqkhzOELE8wciMpAfNdxiWSw7lZ6iwKbreRVDo /sLMhETxgBJhZBXUninhBqFWUA0n/pZWntva60R4fvQdUermX5gXHGG6EtDehfHS6DfQ LooXyJyIaxpeYLZWYAuQw6I0NMPCZdOma6Rkw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; b=cPnT1AGY25QLlpORoU0tp965v/J9m2r4zUOILNAzKOQQLhfBq4nF32TvDDUVNcr+Nc ghVUADuUc/232mh1FU5gLo+dmkrfkfb2RR0zmzOLMaBzh9zLvX5x567gq5jFTdNVi/PD JyaGpi/ERpu3jMuA6GV9PNIbMbo9MxEpOJnAo= Received: by 10.204.98.130 with SMTP id q2mr2706660bkn.31.1295800562043; Sun, 23 Jan 2011 08:36:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.204.52.19 with HTTP; Sun, 23 Jan 2011 08:35:31 -0800 (PST) In-Reply-To: <4D3C565A.7060009@janh.de> References: <4D39FEBA.3000806@janh.de> <4D3AF40E.7090301@janh.de> <4D3C565A.7060009@janh.de> From: Chris Rees Date: Sun, 23 Jan 2011 16:35:31 +0000 Message-ID: To: Jan Henrik Sylvester Content-Type: text/plain; charset=ISO-8859-1 Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: utisoft@gmail.com List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2011 16:36:04 -0000 On 23 January 2011 16:24, Jan Henrik Sylvester wrote: > On 01/23/2011 11:42, Chris Rees wrote: >> >> Take a look at the new patch so far; I'm still working on Busybox at >> the moment, so I'm afraid I can't step too much more through it, but > > Just a question about what you did so far: Why the > "CONFIGURE_ARGS+=--prefix=${PREFIX}"? I have tested with a different PREFIX > before and it was successful -- that is what the second part of the > REINPLACE accomplished. What does your line improve? > > Or is it a first step, if I wanted to make the port DATADIR-safe? > >> it should give you a little more to work on. I've tidied the REINPLACE >> lines for you too. > > Thanks, that is better to read. > >> http://www.bayofrum.net/~chris/patches/xournal.diff >> >> DATADIR-safe appears unnecessary according to the conversation >> http://www.mailinglistarchive.com/freebsd-ports@freebsd.org/msg08234.html >> , so I think that this port should be fine as is right now. Try >> submitting it, it should be fine. > > That is what I thought and since I would have to patch the source (at least > main.c) and the Mafile(s), I did not consider it to be worse it, since I do > not believe anyone will ever use a different DATADIR for this port. > > That leads to my second question: Is your proposal to replace the > "share/xournal" in pkg-plist by "%%DATADIR%%" correct although the port is > not DATADIR-safe? Currently, if DATADIR is set the port ends up to be > installed with wrong +CONTENTS, since the installation ignores DATADIR being > set, but +CONTENTS uses it. > > I believe that it is correct what portlint says: "If and only if your port > is DATADIR-safe (that is, a user can override DATADIR when building this > port and the port will still work correctly) consider using DATADIR macro; > if you are unsure if this port is DATADIR-safe, then ignore this warning". > Thus, there should not be DATADIR in my pkg-plist as long as the port is not > DATADIR-safe. > Perhaps you should ignore the portlint warnings and leave it as share/xournal then. If you stick up a PR with it attached, it looked absolutely fine by me either way! Chris