From owner-cvs-src@FreeBSD.ORG Wed May 14 04:38:02 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5DCF37B401; Wed, 14 May 2003 04:38:02 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id A932643FB1; Wed, 14 May 2003 04:38:01 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h4EBbxYP030441; Wed, 14 May 2003 13:37:59 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: "Greg 'groggy' Lehey" From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 14 May 2003 17:40:41 +0930." <20030514081041.GD4390@wantadilla.lemis.com> Date: Wed, 14 May 2003 13:37:59 +0200 Message-ID: <30440.1052912279@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_disk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 May 2003 11:38:03 -0000 In message <20030514081041.GD4390@wantadilla.lemis.com>, "Greg 'groggy' Lehey" writes: >malloc() of "16" with the following non-sleepablelocks held: >exclusive sleep mutex g_xup r = 0 (0xc8612ca8) locked @ /src/FreeBSD/5-CURRENT-ZAPHOD/src/sys/geom/geom_io.c:363 This is a problem, you cannot sleep in the primary I/O path (ie: strategy() and done()), if you sleep in the I/O path, you stop all I/O processing and if the system needs to page something out to make the ram available to you, you have a deadlock. >panic: final g_dev_close() with outstanding bios This means that close was called before all the I/O requests had been delivered, this is not allowed. You have to stop sending I/Os, wait for the ones you have sent to come back, then you can close. Otherwise the I/O's arriving after the close will be very likely to access stuff which is no longer there, and result in really weird random memory corruption. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.