From owner-freebsd-current@FreeBSD.ORG Thu Dec 21 12:33:21 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D66A416A508; Thu, 21 Dec 2006 12:33:21 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id C458513C45D; Thu, 21 Dec 2006 12:33:17 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id kBL4n0Xq063518; Thu, 21 Dec 2006 07:49:00 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.3/Submit) id kBL4mxA5063517; Thu, 21 Dec 2006 07:49:00 +0300 (MSK) (envelope-from yar) Date: Thu, 21 Dec 2006 07:48:59 +0300 From: Yar Tikhiy To: Coleman Kane Message-ID: <20061221044859.GB63112@comp.chem.msu.su> References: <20061218153906.GA6910@ramen.coleyandcheryl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061218153906.GA6910@ramen.coleyandcheryl> User-Agent: Mutt/1.5.9i Cc: freebsd-current@freebsd.org Subject: Re: UFS_GJOURNAL and ufs.ko X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Dec 2006 12:33:21 -0000 On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote: > Hello, > > I have noticed (since adding UFS journal support) that the > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel > module. I've been using this (out of an effort to test as > much as possible as KLDs) and every time I upgrade my kernel > I must manually add -DUFS_GJOURNAL to the CFLAGS line in > its Makefile. > > Is there any specific reason why this can't be committed? > So far, my experience with GJOURNAL has been great testing > it both with journal+fs on the same device as well as on > two seperate devices. > > It looks like an oversight to me, but I don't want to jump > the gun on it if there is some reasonable argument to keep > it out "by default". If I understand you right, you run a custom kernel w/o UFS and load the latter as a module, don't you? If so, just add "options UFS_GJOURNAL" to your kernel config file, and the module should pick up the setting from the kernel build directory then, granted you build modules with the kernel, not with the world. IMHO CFLAGS should go away from ufs.ko's Makefile because the module should get SOFTUPDATES and UFS_DIRHASH from the kernel configuration, too. -- Yar