From owner-freebsd-current@FreeBSD.ORG Mon Jan 22 07:35:15 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7F15D16A402 for ; Mon, 22 Jan 2007 07:35:15 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.237]) by mx1.freebsd.org (Postfix) with ESMTP id 3C7BF13C457 for ; Mon, 22 Jan 2007 07:35:15 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by wx-out-0506.google.com with SMTP id s18so1206319wxc for ; Sun, 21 Jan 2007 23:35:14 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:subject:message-id:reply-to:mime-version:content-type:content-disposition:user-agent; b=Zk4OM6NlPG7Wyb+4EYeSGu6aW6bhkFwBp0BIpqdbmRx1agWvkUjyOX+vWFSC7UwfpFcowr7K2NDRqzdQJ1PZoJ+bddICKk26VbktyXfAKYwVdnIO1tieZxEIJ0eFplKVmTqhAsm7xrM24d2gq4e4UycQkBn5A6+AqEIyX9cpfc4= Received: by 10.70.17.1 with SMTP id 1mr286925wxq.1169451314630; Sun, 21 Jan 2007 23:35:14 -0800 (PST) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id 25sm9062453wra.2007.01.21.23.35.12; Sun, 21 Jan 2007 23:35:13 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l0M7aBhS030584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 22 Jan 2007 16:36:11 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l0M7aBJQ030583 for freebsd-current@FreeBSD.org; Mon, 22 Jan 2007 16:36:11 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 22 Jan 2007 16:36:11 +0900 From: Pyun YongHyeon To: freebsd-current@FreeBSD.org Message-ID: <20070122073611.GC29223@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="R3G7APHDIzY6R/pk" Content-Disposition: inline User-Agent: Mutt/1.4.2.1i Cc: Subject: Call for re(4) checksum offload testers. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 07:35:15 -0000 --R3G7APHDIzY6R/pk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, It seems that some revisions of re(4) hardwares(PCIe variants?) still have Tx checksum offload issues. One user reported the issue said the attached patch fixed the issue on his box. Since there are lots of hardwares supported by re(4) I'd like to know whether the attached patch has no other regressions on re(4) hardwares. If there are no objections I'll commit it in a week. Thanks. -- Regards, Pyun YongHyeon --R3G7APHDIzY6R/pk Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="if_re.csum.patch" Index: if_rlreg.h =================================================================== RCS file: /home/ncvs/src/sys/pci/if_rlreg.h,v retrieving revision 1.64 diff -u -r1.64 if_rlreg.h --- if_rlreg.h 16 Jan 2007 20:35:23 -0000 1.64 +++ if_rlreg.h 20 Jan 2007 05:05:21 -0000 @@ -443,7 +443,12 @@ #define RL_RX_BUF_SZ RL_RXBUF_64 #define RL_RXBUFLEN (1 << ((RL_RX_BUF_SZ >> 11) + 13)) #define RL_TX_LIST_CNT 4 -#define RL_MIN_FRAMELEN 60 +/* + * re(4) hardware IPv4 Tx checksum offload could be mangled with 28 bytes + * or less IP packets. + */ +#define RL_TXCSUM_MINLEN 28 +#define RL_MIN_FRAMELEN (ETHER_HDR_LEN + RL_TXCSUM_MINLEN) #define RL_TXTHRESH(x) ((x) << 11) #define RL_TX_THRESH_INIT 96 #define RL_RX_FIFOTHRESH RL_RXFIFO_NOTHRESH --R3G7APHDIzY6R/pk--