Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Nov 2018 13:22:35 +0100 (CET)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Rene Ladan <rene@FreeBSD.org>, Michael Reifenberger <mr@FreeBSD.org>,  Emanuel Haupt <ehaupt@FreeBSD.org>, Steve Wills <swills@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r483807 - in head: Mk Mk/Uses audio/kwave audio/logitechmediaserver audio/supercollider audio/teamspeak3-server audio/wavpack audio/zynaddsubfx base/binutils cad/calculix cad/linuxcnc-d...
Message-ID:  <alpine.LSU.2.21.1811031311210.15730@anthias.pfeifer.com>
In-Reply-To: <201811021332.wA2DWZPm025383@repo.freebsd.org>
References:  <201811021332.wA2DWZPm025383@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 2 Nov 2018, Rene Ladan wrote:
> URL: https://svnweb.freebsd.org/changeset/ports/483807
> 
> Log:
>   Remove compatibility code for FreeBSD < 11.2 from all ports.
>   
>   Simplify some ports where DragonFlyBSD no longer needs to be special-cased.
>   Submitted by:	rene
>   Reviewed by:	bapt, jbeich
>   Differential Revision:	https://reviews.freebsd.org/D17724

> Modified: head/cad/openscad/Makefile
> ==============================================================================
> -#.if ${ARCH} == i386 && ${OSVERSION} >= 1100000
> +#.if ${ARCH} == i386
>  #USE_GCC=        yes
>  #.endif

Yes, but this was dead code before and is still dead code.

Okay to remove this, Michael?

> Modified: head/devel/heimdall/Makefile
> ==============================================================================
>  # does not compile with clang 6.0.0
> -.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1101513
> +.if ${OPSYS} == FreeBSD
>  USE_GCC=	yes
>  .endif

Yes, but shouldn't the .if simple be removed now?

Okay, to do so, Emanuel?

> Modified: head/devel/libzim/Makefile
============================================================================
> # Using gcc6 and libstdc++ leads to error because xapian-core is linked with libc++
> -BROKEN_FreeBSD_10=     /usr/include/c++/v1/memory:4004:35: error: no viable overloaded '='

That comment now became obsolete, so I went ahead and remove it
(revision 483889).  Hope you're fine, Steve.

Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.21.1811031311210.15730>