Date: Tue, 5 Jul 2005 11:25:21 -0700 From: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> To: Gleb Smirnoff <glebius@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph netgraph.h ng_base.c ng_socket.c ng_socketvar.h Message-ID: <bb4a86c7050705112517c2f52b@mail.gmail.com> In-Reply-To: <20050705180335.GB5440@cell.sick.ru> References: <200507051735.j65HZK06019006@repoman.freebsd.org> <bb4a86c705070510541eb492b1@mail.gmail.com> <20050705180154.GA5440@cell.sick.ru> <20050705180335.GB5440@cell.sick.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Gleb, i took a brief look at the code, and, i think, everything should be fine. as stated in the commit message EINPROGRESS can only be returned if sender asked for it, i.e. passed the NG_PROGRESS flag to the ng_snd_item(). since none of the NG_SEND_MSG_HOOK(), NG_SEND_MSG_PATH(), NG_SEND_MSG_ID(), NG_FWD_MSG_HOOK() and NG_RESPOND_MSG() macros pass the NG_PROGRESS flag to the ng_snd_item() then this change should have no effect of the current code. sorry for the noise, i just wanted to make sure we do not have change existing code to check for EINPROGRESS error. thanks, max On 7/5/05, Gleb Smirnoff <glebius@freebsd.org> wrote: > On Tue, Jul 05, 2005 at 10:01:54PM +0400, Gleb Smirnoff wrote: > T> It can affect userland code. But only if there are some errors in code= . >=20 > I mean: it can affect userland programs, if there are erros in kernel sid= e. > In this commit, or in related code. If everything is correct, it won't > affect anything. >=20 > I run mpd for several weeks with this patch. >=20 > -- > Totus tuus, Glebius. > GLEBIUS-RIPN GLEB-RIPE >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bb4a86c7050705112517c2f52b>