Date: Thu, 5 Jun 2008 03:17:29 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Remko Lodder <remko@FreeBSD.org> Cc: Maxim Sobolev <sobomax@FreeBSD.org>, src-committers@FreeBSD.org, Florent Thoumie <flz@FreeBSD.org>, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, Steve Kargl <sgk@troutmask.apl.washington.edu>, Wilko Bulte <wb@freebie.xs4all.nl>, Coleman Kane <cokane@FreeBSD.org> Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c pkg_add.1 src/usr.sbin/pkg_install/create main.c pkg_create.1 src/usr.sbin/pkg_install/delete main.c pkg_delete.1 src/usr.sbin/pkg_install/info main.c pkg_info.1 ... Message-ID: <20080605031728.GA94057@FreeBSD.org> In-Reply-To: <4846F743.3040903@FreeBSD.org> References: <a01628140806030818te29e2fet287d59f5ceedfc9c@mail.gmail.com> <20080604041815.GA84027@FreeBSD.org> <20080604043955.GA38627@troutmask.apl.washington.edu> <20080604063631.GA28351@freebie.xs4all.nl> <20080604150013.GA44358@troutmask.apl.washington.edu> <20080604191339.GA31570@freebie.xs4all.nl> <20080604192955.GA46284@troutmask.apl.washington.edu> <4846EF10.1020803@FreeBSD.org> <4846F30A.5070204@FreeBSD.org> <4846F743.3040903@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 04, 2008 at 10:12:51PM +0200, Remko Lodder wrote: > Maxim Sobolev wrote: > > > > For consistency, getopt(3) should be used to parse options. Options > > should be sorted in the getopt(3) call and the switch statement, > >unless > > parts of the switch cascade. Elements in a switch statement that > >cascade > > should have a FALLTHROUGH comment. Numerical arguments should be > >checked > > for accuracy. Code that cannot be reached should have a NOTREACHED > >com- > > ment. > > > >There is nothing about getopt_long(3) being acceptable > >replacement/addition to the getopt(3). > > > > getopt(3) is implemented, and it's expanded by getopt_long(3) in this > case. The requirement is fullfilled and made more readable (in my > eyes) then before. It breaks *consistency* across vast majority of BSD utilities. Also, being readable in your eyes does not automagically make them so in others'. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080605031728.GA94057>