Date: Sat, 1 Feb 2014 08:36:38 +0800 From: Huang Wen Hui <huanghwh@gmail.com> To: "Danilo E. Gondolfo" <danilo@freebsd.org> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Apple Trackpad driver Message-ID: <CAB8uncY9Qo-SJHKc_R1=Q-XpJBqhAzQ=gR5Uvku3C0Hh6o=qMg@mail.gmail.com> In-Reply-To: <52EC3B6C.20202@freebsd.org> References: <CAB8uncaLEn4CaJv8%2BowESe_zUUK%2Bgem_bXpEjhsOJE69m_fWAg@mail.gmail.com> <CAJ-Vmon4Gk6bqoT%2BJf-bRxE0%2BNJ1NjR0wjum-HjoVFDN-2e=8Q@mail.gmail.com> <CAASDrV=pbDpZCGvEjnD8VS0D_HyC8=L3jQ7rfGszG6=PtxaE3Q@mail.gmail.com> <CAASDrVmqijq51OEH7USLutPSgme7YWhXZZX4tGROLHVPoz2VkA@mail.gmail.com> <52E8DDA3.3070301@bitfrost.no> <CAB8uncZVCbFWhJrEosRtRebRip4HjArsZx9FwKE0q9EjYDncmg@mail.gmail.com> <52E9F546.9090005@bitfrost.no> <CAB8unca0ViSrg9ExGX%2BsEfQta9AAXbkKoaGr8RLX1-ksay2tog@mail.gmail.com> <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org> <52EC2889.9020107@bitfrost.no> <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> <52EC3B6C.20202@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, I tried to add to support modem macbooks into atp(4) at the beginning, but realized that atp(4) is very different from new touchpad hardware, so I give up, I think some one can do that. Cheers, Huang Wen Hui 2014-02-01 Danilo E. Gondolfo <danilo@freebsd.org>: > On 01/31/14 21:45, =E9=BB=84=E6=96=87=E8=BE=89@Gmail wrote: > > Hi Hans, > > Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we > can add a notice about that. Table and some structure bt_data, tp_finger > from Linux, I only wrote wsp_intr_callback base on usbdump, all other par= t > should be belong to Hans. > > > > Cheers, > > > > Huang Wen Hui > > > >> =E5=9C=A8 2014=E5=B9=B42=E6=9C=881=E6=97=A5=EF=BC=8C6:49=EF=BC=8CHans = Petter Selasky <hps@bitfrost.no> =E5=86=99=E9=81=93=EF=BC=9A > >> > >>> On 01/31/14 21:30, Danilo E. Gondolfo wrote: > >>>> On 01/31/14 05:16, Hans Petter Selasky wrote: > >>>>> On 01/31/14 02:46, Huang Wen Hui wrote: > >>>>> Hi Hans, > >>>>> > >>>>> pos_x[] is not non-inialized, it may be previous pos_x, it is stil= l > >>>>> ok for > >>>>> getting dx. > >>>>> "n" var is trying to reduce "untouch" sensor data for post > >>>>> proccessing. I > >>>>> attach a new patch > >>>>> may be more clear, also fixed unexpected movement when button statu= s > or > >>>>> ntouch changing. > >>>>> > >>>>> Cheers, > >>>>> > >>>>> Huang Wen Hui > >>>> Hi, > >>>> > >>>> http://svnweb.freebsd.org/changeset/base/261315 > >>>> > >>>> --HPS > >>> Good work! > >>> > >>> I noticed that your driver is based on the Linux driver [1] and some > >>> pieces of code are copied, are you sure that we won't have any proble= ms > >>> with license? > >>> > >>> These changes can be (should be) merged in the driver atp(4), no? > >>> > >>> Danilo. > >>> > >>> > >>> [1] - > http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c > >> Hi, > >> > >> It looks to me like some tables have been copied. We probably should > add a notice about that. The rest of the code looks OK to me. > >> > >> Huang, any comments? > >> > >> --HPS > >> > > > > Hello, > > And what about keeping these two driver? (atp and wsp) > Both has the same purpose. Wouldn't be better merge the new code on atp? > > On freebsd-drivers@ the author of the atp driver started a thread about > this [1]. > > Danilo. > > [1] - > http://lists.freebsd.org/pipermail/freebsd-drivers/2014-January/001659.ht= ml > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAB8uncY9Qo-SJHKc_R1=Q-XpJBqhAzQ=gR5Uvku3C0Hh6o=qMg>