Date: Tue, 8 Apr 2003 17:36:25 +0200 From: Guido van Rooij <guido@gvr.org> To: Maxime Henrion <mux@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c Message-ID: <20030408153625.GA78927@gvr.gvr.org> In-Reply-To: <200304081305.h38D5CGH038749@repoman.freebsd.org> References: <200304081305.h38D5CGH038749@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 08, 2003 at 06:05:12AM -0700, Maxime Henrion wrote: > mux 2003/04/08 06:05:12 PDT > > FreeBSD src repository > > Modified files: > sys/dev/fxp if_fxp.c > Log: > Fix the hangs people have been seeing. For some reason, the > atomic operation change caused this, so backout it until I > can figure out what's wrong with it. FRom the look of it, it seems you have an error in your patch. Shouldn't: atomic_clear_32((u_int32_t *)&last->tx_cb->cb_status, htobe32(bswap16(FXP_CB_COMMAND_S))); be: atomic_clear_32((u_int32_t *)&last->tx_cb->cb_command, htobe32(bswap16(FXP_CB_COMMAND_S))); -Guido
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030408153625.GA78927>