Date: Sat, 19 Oct 2013 16:19:26 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Danilo Egea Gondolfo <danilo@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r330645 - head/audio/audacity Message-ID: <20131019161926.GA55883@FreeBSD.org> In-Reply-To: <20131019180942.09929707@kalimero.tijl.coosemans.org> References: <201310171430.r9HEUJZY033529@svn.freebsd.org> <20131017171050.2ce0ae53@kalimero.tijl.coosemans.org> <20131019113111.GA78540@FreeBSD.org> <20131019180942.09929707@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 19, 2013 at 06:09:42PM +0200, Tijl Coosemans wrote:
> I looked into why the port is trying to use SSE on PowerPC and it looks
> like there's a bug in the Makefile: SSE_CONFIGURE_WITH=sse should be
> SSE_CONFIGURE_ENABLE=sse. And "SSE" should be moved from OPTIONS_DEFAULT
> to OPTIONS_DEFAULT_amd64. Then you can remove SSE_CFLAGS everywhere.
>
> The question is if this should be an option at all. I think it's ok to
> just enable SSE on all CPUs that support it like this:
>
> .if ${MACHINE_CPU:Msse}
> CONFIGURE_ARGS+= --enable-sse
> .else
> CONFIGURE_ARGS+= --disable-sse
> .endif
Yes, that's what I was thinking of. This way, package cluster will produce
universally runnable packages (since it defaults to i486), and correctly
optimized binaries when user sets his CPUTYPE in /etc/make.conf.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131019161926.GA55883>