From owner-svn-src-stable-12@freebsd.org Tue Feb 12 16:31:56 2019 Return-Path: Delivered-To: svn-src-stable-12@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D4EE14EC06B for ; Tue, 12 Feb 2019 16:31:56 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C9A9B6D242 for ; Tue, 12 Feb 2019 16:31:55 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1CGVqvb076721; Tue, 12 Feb 2019 08:31:52 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1CGVqWE076720; Tue, 12 Feb 2019 08:31:52 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902121631.x1CGVqWE076720@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs In-Reply-To: To: Warner Losh Date: Tue, 12 Feb 2019 08:31:52 -0800 (PST) CC: "Rodney W. Grimes" , Dmitry Morozovsky , Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C9A9B6D242 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 16:31:56 -0000 > On Tue, Feb 12, 2019 at 9:21 AM Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > On Tue, 12 Feb 2019, Cy Schubert wrote: > > > > > > > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry > > > > Morozovsky wr > > > > ites: > > > > > Author: marck (doc committer) > > > > > Date: Tue Feb 12 13:58:16 2019 > > > > > New Revision: 344051 > > > > > URL: https://svnweb.freebsd.org/changeset/base/344051 > > > > > > > > > > Log: > > > > > MFC 343548: > > > > > > > > > > Allow dashes as a valid character in UFS labels. > > > > > > > > Approved by: Whom? > > > > > > Sorry, I missed commit log metadata from the original change. > > > > > > Lesson learnt. > > > > I think your fine on how you did this, I certainly already > > knew from reading the ^head commits that this change had > > infact been approved by Kirk, and had been flagged for MFC. > > > > I do not see value in duplicationg all that info in the > > stable branches, but perhaps we should formalize that in > > the committers guide on commit messages? > > > > Let's not overreact. Someone made a commit, someone else didn't go check > the original commit to see it was legit and asked a question. The original > bonafides were provided. Case closed. No need to make a federal case out of > it. The doc committer learned to take a little extra care on their commit > messages, it seems, as doc committers committing to src get a little extra > scrutiny. The original complainer likely noticed the info was in the > original commit and may check there in the future before complaining. Or > maybe he won't. It isn't a big deal either way. > > None of this requires a change to the rules. I advocating better documenting better how we want to operate, if you see no value in that, so be it, but imho we are way to large and way to loose to continue to funciton in the manner we have been. If all of our process was better documented and layed down we would have less of this type of discussion on a much less frequent basis. Again, imho, this is not an over reaction, but a simple reaction to what occurred, with a proposed, and what imho, is a reasonable step forward, rather than just staying at status quo. New committers need to know many more things than what is currently in our committers guide, lets improve that. -- Rod Grimes rgrimes@freebsd.org