From owner-dev-commits-ports-all@freebsd.org Fri Apr 23 21:53:26 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BB265E071F; Fri, 23 Apr 2021 21:53:26 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FRp2G2vpYz3N8y; Fri, 23 Apr 2021 21:53:26 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from mandree.no-ip.org (p200300d0273BA900E74eb1A213E3DB8c.dip0.t-ipconnect.de [IPv6:2003:d0:273b:a900:e74e:b1a2:13e3:db8c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 3810622679; Fri, 23 Apr 2021 21:53:26 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from ryzen.an3e.de (localhost [IPv6:::1]) by ryzen.an3e.de (Postfix) with ESMTP id 73FF212019F; Fri, 23 Apr 2021 23:53:23 +0200 (CEST) From: Matthias Andree Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. To: Gleb Popov , Mathieu Arnold Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <20210422101616.c3i7dn6gfm6hhner@aching.in.mat.cc> <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> Message-ID: Date: Fri, 23 Apr 2021 23:53:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 21:53:26 -0000 Am 22.04.21 um 13:23 schrieb Gleb Popov: > > > On Thu, Apr 22, 2021 at 1:49 PM Mathieu Arnold > wrote: > > Then you are misusing Submitted by.  Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else.  If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. > > -- > Mathieu Arnold > > > In the past I sometimes used "Submitted by (someguy, initial patch)" and > still think it is a good thing. > > Creating an initial port is not only about typing something in the text > editor, but also figuring out how to build the software. This is also > quite an effort sometimes, invisible for the commiter, and I believe it > should be credited. I concur, and I will pull out something that was proposed between the lines in this thread already: 1. use the original patch and commit with --author attribution. Do not push yet. 2. polish, touch-up, refine it as committer or integrator, and commit that with author = committer 3. git pull --rebase --autostash, git push 4. optionally, MFH