From owner-cvs-all@FreeBSD.ORG  Sun Jul  3 14:36:21 2011
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B16C3106564A;
	Sun,  3 Jul 2011 14:36:21 +0000 (UTC)
	(envelope-from utisoft@gmail.com)
Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com
	[209.85.210.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 43C738FC1A;
	Sun,  3 Jul 2011 14:36:21 +0000 (UTC)
Received: by iyb11 with SMTP id 11so5243240iyb.13
	for <multiple recipients>; Sun, 03 Jul 2011 07:36:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:from:date
	:x-google-sender-auth:message-id:subject:to:cc:content-type;
	bh=zIMU6MBJ42R4JbClloomH29D07eDdNM1lci0VtdvdGM=;
	b=CjFqph1/Zdnw3H0g3QxroBw29Zd+gcMoBN/H2L07AIiAQQuEGwmzeqwDAz9LttOkN7
	JPa2cIQmYMzVcVQkjoT0aidMUmPh1gcGVDK41FYHONiupHpHsVLUfLFqVkhGhgua9sJy
	Pe9aEJJ6WzRyvxjesusKnAcoA769ChAd/jvdc=
Received: by 10.231.81.83 with SMTP id w19mr4639389ibk.34.1309703780081; Sun,
	03 Jul 2011 07:36:20 -0700 (PDT)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.231.155.141 with HTTP; Sun, 3 Jul 2011 07:35:50 -0700 (PDT)
In-Reply-To: <4E105B9B.4060602@os2.kiev.ua>
References: <201107021323.p62DNWeP082020@repoman.freebsd.org>
	<4E0FB8DF.90904@FreeBSD.org> <4E105B9B.4060602@os2.kiev.ua>
From: Chris Rees <crees@freebsd.org>
Date: Sun, 3 Jul 2011 15:35:50 +0100
X-Google-Sender-Auth: e4WPRJ0BYD9JHXhnUQYRVhGEJZU
Message-ID: <CADLo83-6dUpPXQB8eDQcGUpzbR16a_hcvQ8fB_t-qeLAWTqeTQ@mail.gmail.com>
To: Alex Samorukov <samm@os2.kiev.ua>
Content-Type: text/plain; charset=ISO-8859-1
Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org,
	Doug Barton <dougb@freebsd.org>, cvs-all@freebsd.org,
	Martin Wilke <miwi@freebsd.org>
Subject: Re: cvs commit: ports/sysutils/atop Makefile distinfo
 ports/sysutils/atop/files atop.in pkg-message.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2011 14:36:21 -0000

On 3 July 2011 13:07, Alex Samorukov <samm@os2.kiev.ua> wrote:
> Hello,
>
> Thank you for comments.
>
> On 07/03/2011 02:33 AM, Doug Barton wrote:
>>
>> Overall this looks good, just 2 small comments. It's not clear why it
>> uses:
>>
>> # REQUIRE: DAEMON
>> # BEFORE: LOGIN
>>
>> Instead of just
>>
>> # REQUIRE: LOGIN
>>
>> like most ports scripts do.
>
> Probably my copypaste from some other script. Better to replace with
> REQUIRE: LOGIN.
>
>> Also the default empty assignment for _flags is neither necessary or
>> desirable.
>
> Agree. Do i need to submit PR to fix this or you can do it without it?

PR is probably best so it doesn't get lost in the mailing list.

Chris