From owner-cvs-src@FreeBSD.ORG Sun Oct 31 09:25:34 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from [IPv6:::1] (hub.freebsd.org [216.136.204.18]) by hub.freebsd.org (Postfix) with ESMTP id 0DE2016A4CE; Sun, 31 Oct 2004 09:25:33 +0000 (GMT) Message-ID: <4184BD2D.9030209@freebsd.org> Date: Sun, 31 Oct 2004 03:23:41 -0700 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.2) Gecko/20040929 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brian Fundakowski Feldman References: <200410310503.i9V53ofj011896@repoman.freebsd.org> <20041031050620.GQ93831@green.homeunix.org> In-Reply-To: <20041031050620.GQ93831@green.homeunix.org> X-Enigmail-Version: 0.86.1.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 09:25:34 -0000 Brian Fundakowski Feldman wrote: > On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote: > >>green 2004-10-31 05:03:50 UTC >> >> FreeBSD src repository >> >> Modified files: >> lib/libpthread/thread thr_mutex.c >> Log: >> Make pthread_mutex_trylock(3) return EBUSY on failure, as all software >> packages expect and seems to be most correct according to the slightly- >> ambiguous standards. >> >> MFC after: 1 month >> Corroborated by: POSIX >> Reviewed by: silence on threads@ > > > Software such as mozilla projects (using NSPR) and Java have been > broken in various ways by this. We need to try to be more compatible > with the most popular interpretation of the standards (instead of just > inventing our own) -- usually we're pretty good about this. > Please define 'broken'? There are many test suites available for pthreads. How does this affect those test suites, and have you _directly_ talked with those who run the tests suites? Scott