Date: Sat, 20 Mar 2021 13:17:58 +0300 From: Gleb Popov <arrowd@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files Message-ID: <CALH631kTzannasMmye9Kee3xg%2BHDK1sZK9d-xA=JFq2Q7n4X9g@mail.gmail.com> In-Reply-To: <20210320081832.GA21788@FreeBSD.org> References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> <CALH631krOy0fzL_V4Sz58z4TCFvEfKvqfCYbWCe=XpkTC99b5Q@mail.gmail.com> <20210320033712.GA18472@FreeBSD.org> <CALH631kuedo7Ch%2BOphQaGW_iru6UOWez7O5xkrZQ51a7Q073aw@mail.gmail.com> <20210320081832.GA21788@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 20, 2021 at 11:18 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Sat, Mar 20, 2021 at 10:38:30AM +0300, Gleb Popov wrote: > > On Sat, Mar 20, 2021 at 6:37 AM Alexey Dokuchaev <danfe@freebsd.org> > wrote: > > ... > > > On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > > > > Exactly this. > > > > > > Understood. Please try to write more elaborate commit logs next time, > > > so everyone could easily see what's going on, not just you or me. > > > > I clearly remember the case where you criticized a committer for a too > > lengthy commit message. I'll try my best next time, anyways. > > That doesn't sound like me at all, I love elaborate commit messages (as > long as they are of why-ish, not what-ish type and not merely translate > the commit diff in English). I'll have to dig into my sent-mail to see > what were the circumstances in that particular case. > IIRC, the commit I was talking about had a Changelog in its description. > > P.S. With all these "do the repocopy!" and "bad commit message!" you're > > really living up to your surname. No offence, just joking. > > I don't understand. There are certain bylaws and even rules of how we do > things in the common repo, those practices are instated to make everyone's > work easier. Waived repocopies and poor commit logs make this harder. > > And I'm not just complaining, I actually go and fix the mess when I see > there's no interest from the original committer. Did I ever get a "thank > you" back? No, I got "you're really living up to your surname" from you. > >From me? Well, it is pretty expectable. I never found myself in a situation when I needed to follow all these repocopies. Why should I be grateful for something not useful for me? To the contrary, I actually do repocopies when required (including when requested by you) and this only adds more work for me. I have to remember the command every time. Trying to be a good developer I'm following the rule, but the rule itself doesn't pay off for me. Everything you say is correct in general, but I'm still having hard times applying it to concrete cases. Speaking of this commit, I don't understand who would ever (except you) want to dig into to figure out a rationale for this patch. It will be gone in the next port update anyways. Until I figure that, I'm afraid I'll keep making these mistakes.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631kTzannasMmye9Kee3xg%2BHDK1sZK9d-xA=JFq2Q7n4X9g>