From owner-svn-src-all@freebsd.org Mon Jan 9 02:25:20 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF1E7CA0502; Mon, 9 Jan 2017 02:25:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9BBA11C31; Mon, 9 Jan 2017 02:25:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x243.google.com with SMTP id f144so4517400pfa.2; Sun, 08 Jan 2017 18:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=15WxPo2dFa02BLg/iHtPHYChOXVKFb6fa5djohrPJVc=; b=MXJX8Ctg/6elx27c1IkGG2cpTDqUk/hAT7s2mJG2JKBcjn1BlApblICSem9jLVndIY hR8Q4KYbDr75ewIy5h7UYDWMdCV1dWd8p+Eb8KyPSNmw0BwSVFj7k5THhrFQ1cc3DzLL DHLbbosMliZdaXGRCYTx93kfJTXlk8K/omPoH527Y5eNrgnkbED1TGFdLrTpxOuhTqOb 2AqsQgZjQZ9NenpIWjiHbhIM7goIP1sGObIxulQleLKfH/bqEUaonz2LS+ZrXdgA6iln L9xSxsRzrhfoQvrfz1OLThYaQHvX59pO6sLCC1DpnPyQKXgc2k1bxjse+Zr8Kl7CEaAU l5OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=15WxPo2dFa02BLg/iHtPHYChOXVKFb6fa5djohrPJVc=; b=n1hTHzW5i39uAS7i6GrBixUC/u/2MXT1qTQ21HM280r/Vo8iA/M7pjCxcxPce9TROH HSgzhcGf1zUpcJ5eZTrRYGXQ3C/Qu9V8s3ozKbAnTTRkv+105UywxtsI2KI3qm3REBQS PZkf+vu5HA1l7B9v34/vLGlFpps6Ekdab8zL/UMFYcgZaB9UoCE+l8vsnBdcGUsKjIKy tooE7gceZJevQXsv38pEPgu6sDuXuROhWvFIgbymI+5/4Ctpf2ph0TxQ1GDoxBhYNRht nJXAoQzjRwRo0G2YjiuUqCSErhrslg14tg7qaGpFguaVmcYCJ35GkBFzFz+YHOy9sJGZ d80g== X-Gm-Message-State: AIkVDXLJWAPCktPsi1tMuJggTGnMneGCb0ivDydLxhH/ZhT5suQTUkEiWh/alN6cnKfLSg== X-Received: by 10.84.216.91 with SMTP id f27mr29815428plj.92.1483928720052; Sun, 08 Jan 2017 18:25:20 -0800 (PST) Received: from [192.168.20.12] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a24sm174345495pfh.57.2017.01.08.18.25.19 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 08 Jan 2017 18:25:19 -0800 (PST) Subject: Re: svn commit: r311667 - in head/sys/contrib/dev/acpica: components/namespace components/tables include Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_FEFBCA4B-3EC2-4CAE-B15E-D892D007ED4B"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <20170109022400.D7E72487A@freefall.freebsd.org> Date: Sun, 8 Jan 2017 18:25:18 -0800 Cc: "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <31477079-EE88-4D42-B006-BB8C1B061DCB@gmail.com> References: <20170109022400.D7E72487A@freefall.freebsd.org> To: Jan Beich X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 02:25:20 -0000 --Apple-Mail=_FEFBCA4B-3EC2-4CAE-B15E-D892D007ED4B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 8, 2017, at 18:24, Jan Beich wrote: >=20 > "Conrad E. Meyer" writes: >=20 >> +++ head/sys/contrib/dev/acpica/components/tables/tbxface.c Sun Jan = 8 06:26:33 2017 (r311667) >> @@ -314,11 +314,12 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader) >>=20 >> = /*************************************************************************= ****** >> * >> - * FUNCTION: AcpiGetTable >> + * FUNCTION: AcpiGetTableWithSize >> * >> * PARAMETERS: Signature - ACPI signature of needed table >> * Instance - Which instance (for SSDTs) >> * OutTable - Where the pointer to the table = is returned >> + * TblSize - Size of the table >> * >> * RETURN: Status and pointer to the requested table >> * >> @@ -333,10 +334,11 @@ ACPI_EXPORT_SYMBOL (AcpiGetTableHeader) >> = **************************************************************************= ****/ >>=20 >> ACPI_STATUS >> -AcpiGetTable ( >> +AcpiGetTableWithSize ( >=20 > Can you adjust ACPI_EXPORT_SYMBOL() as well? It doesn't make sense to > export AcpiGetTable() twice but compiler won't complain if you do. Depends on the compiler and the version. IIRC clang won=E2=80=99t, but = gcc will (depending on the version). Cheers, -Ngie --Apple-Mail=_FEFBCA4B-3EC2-4CAE-B15E-D892D007ED4B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYcvSOAAoJEPWDqSZpMIYVEtwP/1cFjNtjU2Fp5oQrp0TGcdUg p34EM859JhAuhFdAqv7LEU66u6c0PMBqZb1nXVvs3O6MGwDig/xvAseUOJChmVkr VOZ6SGKSlkRvv4tDgypRuDYKqej2o7XGKCZW2HFQPqyOOyFfZvPbvgJusVKbvOJB vX8+jKbqt2jB3Kn8RUWJl7a2RRymDhcNHZcv3RVhHin2jNs79883Ek143dT37yxD NmMkldDI9DILxPAWxDyfVopSjgdC8HL08HO8RRH4zeqfd7eSdnrYvaD/aDOEmWZt h2z/cNTPSd8qJ83TTe3VMhCUWbYGr/z0GfWYyPRyR2wKgN79C9NoPVD+OI342uXD cjq5Xo0BEYZLOZOqG1mhV9Cvmi8WWrbMlRgMd7yBDbCiIFH4s0bRDRGEjcefglS9 Ti+Wh3R5M51RRgjJOLxs0qMSbdtXM+7qaYtOz49lQeRfrZdnlDrDu3nqjCMOUGap EyU4cihxqKLFqGS/Wj/ifq7Onx2RmHnhTzuex9godyzPdttwXRRzquukr7HFGy20 9lskFBeEgLicWjLq+wu+TmRgLt9HCYnJKp60hGunuwMZHUqJNbFKPU/fl6l1IBja U9JLBOJojteSs1zlsWltKxc6aVIYfv98dZKCIvaFydxGg0sPd2pOJSj7eKVBhW8b VwnomwcNNROiqKXsLjeD =btMk -----END PGP SIGNATURE----- --Apple-Mail=_FEFBCA4B-3EC2-4CAE-B15E-D892D007ED4B--