Date: Fri, 18 May 2001 16:05:23 -0700 From: John Reynolds~ <jreynold@sedona.ch.intel.com> To: Nik Clayton <nik@freebsd.org> Cc: doc@freebsd.org Subject: Re: Policy on image source files in the CVS tree Message-ID: <15109.43699.126204.944263@hip186.ch.intel.com> In-Reply-To: <20010518224728.C1757@catkin.nothing-going-on.org> References: <20010517122744.B3349@catkin.nothing-going-on.org> <20010517113103.A25222@Odin.AC.HMC.Edu> <200105180028.f4I0Snn05073@bmah-freebsd-0.cisco.com> <20010518013645.A8358@catkin.nothing-going-on.org> <15109.16691.817238.944467@hip186.ch.intel.com> <20010518184813.B12846@catkin.nothing-going-on.org> <15109.25794.690992.994411@hip186.ch.intel.com> <20010518224728.C1757@catkin.nothing-going-on.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ On Friday, May 18, Nik Clayton wrote: ]
>
> D'oh. shot2png.
>
> Sounds reasonable. Try the attached, which is controlled by the "-l"
> flag. I've also included a dump of sysinstall's startup screen -- try
> running shot2.scr through shot2png and the attached shot2txt, with and
> without the -l flag.
>
> N
yeah--that looks good Nik! Though, I spotted one foobar in the code. I just
saw you created a port so I betcha you already saw this and asynchronously
fixed it, but you had:
if(!strcmp(MAGIC, header))
err(1, "Expecting '%s', read '%s'", MAGIC, header);
but I belive you meant:
if(strcmp(MAGIC, header))
err(1, "Expecting '%s', read '%s'", MAGIC, header);
otherwise, the SCRSHOT_ header is read successfully but we bail incorrectly:
dolphin [~]<77>% ./shot2txt < shot2.scr
shot2txt: Expecting 'SCRSHOT_', read 'SCRSHOT_': Undefined error: 0
But yeah, your mappings make things look good!
-Jr
--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
| John Reynolds WCCG, CCE, (space for rent, cheap!) |
| Intel Corporation MS: CH6-210 Phone: 480-554-9092 pgr: 602-868-6512 |
| jreynold@sedona.ch.intel.com http://www-aec.ch.intel.com/~jreynold/ |
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15109.43699.126204.944263>