From owner-freebsd-ports@FreeBSD.ORG Thu Nov 14 17:49:12 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 12CF44D3; Thu, 14 Nov 2013 17:49:12 +0000 (UTC) Received: from mail-wg0-x22d.google.com (mail-wg0-x22d.google.com [IPv6:2a00:1450:400c:c00::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 812C62F1F; Thu, 14 Nov 2013 17:49:11 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id a1so2417744wgh.24 for ; Thu, 14 Nov 2013 09:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=gE31cWsJXfPn6DUENJDfDT0CORLlH0Dn0iN1G98A8kg=; b=KMn7RoO/nFbBHQSnlQ0eBdT44UuCO45PcIj9vPA6OnOKQyTbhk6/OQ9KtI/Cde0FN3 snKW/PNE9j1+5zGoy3gsEVVgqU0QxYuA3EJiPsZOZKwQ84f2+DBt+d8qWH6Tgg3jlZuN NoZ2kMTXJAomKNunJHP6hDpH0ftD0jrKtrAjxZOCFLZ1DFDW1By+O6ZveUsEY0M2OHTT 5RhTNXM9R/MqX/MBNx/1EwzAN6SHayV4FlrzmaTMmMrYs8kQhhVZG4DdnIIy+53B6MS+ iYqbceWPjsv/IsIYuXZMzWlCEJdCI/bUx1mEyJT3I92Yoo2rodUg3jmTBvJ6wBRYO2eK YLFA== X-Received: by 10.194.88.225 with SMTP id bj1mr3193140wjb.50.1384451349877; Thu, 14 Nov 2013 09:49:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.197.10 with HTTP; Thu, 14 Nov 2013 09:48:49 -0800 (PST) In-Reply-To: <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org> References: <88E1B73E-10D0-4949-A35C-52927187F84C@FreeBSD.org> From: Chad Gross Date: Thu, 14 Nov 2013 12:48:49 -0500 Message-ID: Subject: Re: NfSen Port PATCH To: Mark Felder Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 17:49:12 -0000 No problem; it happens. Chad On Wed, Nov 13, 2013 at 5:20 PM, Mark Felder wrote: > > On Nov 13, 2013, at 12:27, Chad Gross wrote: > > > I found an issue with the nfsen port Makefile. It is not properly > > configured to expand the %%PORTNAME%% variable used when generating the > > nfsen config file. > > > > > > For example, the config that is installed shows this: > > > > $VARDIR=3D"${BASEDIR}/var/%%PORTNAME%%"; > > > > > > When it should be this: > > > > $VARDIR=3D"${BASEDIR}/var/nfsen"; > > > > I have attached the patch, but also included it in-line below. I emaile= d > > the maintainer, but hadn't heard a response so figured I would send it > here > > just in case. > > > > > > --- Makefile 2013-11-03 12:31:00.000000000 -0500 > > > > +++ Makefile.new 2013-11-03 12:30:51.000000000 -0500 > > > > @@ -37,6 +37,7 @@ > > > > SUB_LIST+=3D "PORTVERSION=3D${PORTVERSION}" > > > > SUB_LIST+=3D "PREFIX=3D${PREFIX}" > > > > SUB_LIST+=3D "WWWDIR=3D${WWWDIR}" > > > > +SUB_LIST+=3D "PORTNAME=3D${PORTNAME}" > > > > > > > > NO_STAGE=3D yes > > > > post-patch: > > > > > > Thanks, > > > > Thanks for catching this. I=92m not sure how I missed this when I rewrote > the port=85 I definitely tested clean installs, but I must have provided = my > own configs > >