From owner-freebsd-current Tue Nov 24 13:08:16 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA06660 for freebsd-current-outgoing; Tue, 24 Nov 1998 13:08:16 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA06653 for ; Tue, 24 Nov 1998 13:08:13 -0800 (PST) (envelope-from archie@whistle.com) Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id NAA16789; Tue, 24 Nov 1998 13:07:11 -0800 (PST) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma016787; Tue, 24 Nov 98 13:06:56 -0800 Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id NAA05958; Tue, 24 Nov 1998 13:06:56 -0800 (PST) From: Archie Cobbs Message-Id: <199811242106.NAA05958@bubba.whistle.com> Subject: Re: snprintf() in the kernel In-Reply-To: <199811240900.BAA13142@apollo.backplane.com> from Matthew Dillon at "Nov 24, 98 01:00:15 am" To: dillon@apollo.backplane.com (Matthew Dillon) Date: Tue, 24 Nov 1998 13:06:56 -0800 (PST) Cc: bde@zeta.org.au, freebsd-current@FreeBSD.ORG, grog@lemis.com, rnordier@nordier.com X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Matthew Dillon writes: > I have a suggestion, why not split the problem up... commit the > kernel snprintf() subroutine first, then put up a small subset of the > snprintf() changes up for review and commit those on a fast track. i.e. > get some of the more obvious sprintf() -> snprintf() fixes in and proven. That makes sense.. especially so people can start using snprintf() if they want, instead of waiting for this discussion to finish.. :-) > Personally, I think we need to move to length-limited copies for all > string operations. The code may be correct as is, and it may seem obvious > to the people who wrote it, but FreeBSD is a collective effort and the > more mistakes we can prevent in the future without compromising code > effectiveness the better. Me too. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message