Date: Thu, 4 Dec 2003 15:03:15 -0600 (CST) From: Loren James Rittle <rittle@latour.rsch.comm.mot.com> To: ports@freebsd.org Subject: PATCH: shells/es to support FreeBSD 5.2 Message-ID: <200312042103.hB4L3FwO039882@latour.rsch.comm.mot.com>
next in thread | raw e-mail | index | archive | help
shells/es has built incorrectly on FreeBSD 5 since a signal, SIGTHR, was added beyond NSIG (circa 3/31/03; I first noticed mid-August). I assume this was not detected on bento since the port is actually made and installed without error. Corresponding with the author of the aforementioned sys/signal.h change, I get the impression that is now considered OK. As the listed shells/es port maintainer, I suggest this patch to resolve the assumption conflict (es assumed that no named signal would ever be present on a system beyond NSIG). Can someone commit it please? (Tested on ref5, beast and my own FreeBSD4 desktop both with and without a hacked-up /usr/include/sys/signal.h. BTW, "ignoring" the signal, as shown in this patch, only affects the text of the reason a process was killed; not how it is actually handled in the shell itself. Since kill(1) doesn't yet know how to support SIGTHR ala `kill -s THR'; I see no reason this port should try any harder...) Thanks, Loren Handle new signal, SIGTHR, beyond NSIG. Index: Makefile =================================================================== RCS file: /home/ncvs/ports/shells/es/Makefile,v retrieving revision 1.14 diff -c -r1.14 Makefile *** Makefile 21 Feb 2003 13:26:58 -0000 1.14 --- Makefile 4 Dec 2003 03:29:03 -0000 *************** *** 7,13 **** PORTNAME= es PORTVERSION= 0.9.b1 ! PORTREVISION= 2 CATEGORIES= shells MASTER_SITES= ftp://ftp.sys.toronto.edu/pub/es/ DISTNAME= es-0.9-beta1 --- 7,13 ---- PORTNAME= es PORTVERSION= 0.9.b1 ! PORTREVISION= 3 CATEGORIES= shells MASTER_SITES= ftp://ftp.sys.toronto.edu/pub/es/ DISTNAME= es-0.9-beta1 Index: files/patch-mksignal =================================================================== RCS file: files/patch-mksignal diff -N files/patch-mksignal *** /dev/null 1 Jan 1970 00:00:00 -0000 --- files/patch-mksignal 4 Dec 2003 03:29:03 -0000 *************** *** 0 **** --- 1,15 ---- + *** mksignal.orig Wed Dec 3 20:59:12 2003 + --- mksignal Wed Dec 3 21:00:50 2003 + *************** + *** 106,111 **** + --- 106,115 ---- + ignore["SIGRTMIN"] = 1 + ignore["SIGSETS"] = 1 + ignore["SIGSTKSZ"] = 1 + + + + # FreeBSD 5 added a signal beyond NSIG; es makes too many + + # assumptions to make this worth fixing. + + ignore["SIGTHR"] = 1 + + # upper to lowercase translation table: can someone give me an easier + # way to do this that works in ancient versions of awk?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312042103.hB4L3FwO039882>