Date: Mon, 10 Jan 2011 05:27:09 -0700 From: Warner Losh <imp@bsdimp.com> To: freebsd-mips@freebsd.org Subject: Re: [PATCH] Support for 64-bit PTEs on n64 Message-ID: <4D2AFB1D.6050104@bsdimp.com> In-Reply-To: <AANLkTi=%2BOKimuq9c6ECk6-VpxTcNiU2AEaaT05Fv8rZi@mail.gmail.com> References: <AANLkTinpdhjO_TXqkS4GRRZDtSG91GZYHhLzYmWi5yf6@mail.gmail.com> <AANLkTi=%2BOKimuq9c6ECk6-VpxTcNiU2AEaaT05Fv8rZi@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/09/2011 22:03, Juli Mallett wrote: > On Sun, Jan 9, 2011 at 20:51, Jayachandran C.<c.jayachandran@gmail.com> wrote: >> Here's my initial code to support>4GB physical memory on MIPS. This >> patch adds 64 bit page table entries in n64 compilation. >> >> I would like to add this as an optional feature for n32/o32 >> compilation with 'option PHYSADDR_64_BIT' later. > This is great! Can you put the PTE-related assembly macros into an > existing header file instead of in the sources? That's the only thing > that really stands out to me. > Agreed. Too many magic constants in magic places. On question, however. The 64-bit PTEs won't get in the way when we're running 32-bit binaries on a 64-bit kernel, will they? Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D2AFB1D.6050104>