From owner-freebsd-fs@FreeBSD.ORG Mon Jul 2 14:22:25 2012 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AEFE4106566B; Mon, 2 Jul 2012 14:22:25 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id DE64B8FC18; Mon, 2 Jul 2012 14:22:24 +0000 (UTC) Received: by lbon10 with SMTP id n10so9508513lbo.13 for ; Mon, 02 Jul 2012 07:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=tAHkgVw5kJ3r56w+xZocmo5AiUeVl2u9KFOnFTLLl6A=; b=YLVQMbSm5FwuQ6KR7SzFqQmZaUNt9U2GWxb4BT5Jv9Df6QwpSc9ZdnCClfKx/wtScA gjJ7MOio1XF3Yg/HDioHX9Od8qp6VPL7fGPlzViBCMufE0db5HCP3qzzS1YqbO5gYhLU dg4Jb5IHBII1jyJBRSw2bSTbgOmdM4N4r66Ec3D7rh+83gNK7n5fxjGnA7rN5tYQnUtY iFo5ReKEy8z2GYLxWyL6Ebr/oG4tKaRLmPkbUPMuV5gQkSILDoP2Srkz1nCVmALDWt1A e2IFxgIENOqopreMI83eXDWPtWH3/WqvmUSR/pG0vmxIruf11kcpCapojB+wdupgLNkw Jiiw== MIME-Version: 1.0 Received: by 10.152.131.9 with SMTP id oi9mr13062883lab.39.1341238943768; Mon, 02 Jul 2012 07:22:23 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Mon, 2 Jul 2012 07:22:23 -0700 (PDT) In-Reply-To: <20120702061219.GA16671@infradead.org> References: <20120702061219.GA16671@infradead.org> Date: Mon, 2 Jul 2012 15:22:23 +0100 X-Google-Sender-Auth: LXn3NQyyCUDaSY6EFW8aBfNtzPI Message-ID: From: Attilio Rao To: Christoph Hellwig Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD FS , Russell Cattelan , freebsd-current@freebsd.org, "C. P. Ghost" Subject: Re: MPSAFE VFS -- List of upcoming actions X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 14:22:25 -0000 2012/7/2, Christoph Hellwig : > On Sun, Jul 01, 2012 at 03:52:05PM +0200, Attilio Rao wrote: >> anything by SoC involved people about NTFS and certainly I don't see a >> plan to get XFS locked. > > Stupid question, but what amount of locking does XFS in FreeBSD still > need? I'm one of the maintainer of XFS on Linux, and while I know > FreeBSD imported a really old version compared to the current one the > codebases on IRIX and later Linux never relied on any global Giant-style > locking. So if there is anything to fix it would be the in the small > bits of FreeBSD-specific code. Basically when it cames to make a MPSAFE filesystem under FreeBSD there are 2 things to pay attention at: filesystem specific locking and dealing with FreeBSD's VFS locking. The former is usually the tricky part because it varies among the filesystems and it is where the developers might have more knowledge. The latter can be helped by testing with a debugging kernel for low hanging fruits, but special attention must be put in things like avoid to put half-constructed vnodes in the mount lists, lookup races (in particular with DOTDOT case) and others. For a reference, one can always look to simple filesystems that are already made MPSAFE (like MSDOS-FS likely). In the XFS case, I think it would be desirable to have a real maintainership. This means, basically, not only work on the locking but really be keen to have a working XFS. At the moment, we might still have write support as well, but it is badly broken. What I suggest for XFS is: - Remove the current write support entirely - Try to bring the sole read support to new(ish) XFS version (at least to a version that is known to not be totally broken) - Fix up the support to work with FreeBSD VFS Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein