Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 03 Aug 2002 00:35:49 +0100
From:      Dominic Marks <dominic_marks@btinternet.com>
To:        freebsd-hackers@freebsd.org
Subject:   very minor vm_map.c typo ?
Message-ID:  <3D4B1755.1030301@btinternet.com>

next in thread | raw e-mail | index | archive | help
Hello,

In vm_map.c, in the vm_map_insert(...) function there is the following 
piece of code which checks if the addresses supplied to the function are 
valid:

**
if ((start < map->min_offset) || (end > map->max_offset) ||
	(start >= end))
	return (KERN_INVALID_ADDRESS);
**

Specifically, I am interested in the final comparison. Is it possible 
that start == end could ever be correct? Do zero sized entries ever get 
inserted? (I don't see why you would ever wish to do this, please 
explain it to me if there is a reason).

Normally I'd submit a PR about this but since its not an area of the 
code I am very familiar with I thought I'd ask. I would also supply a 
patch but for a one character change it seems pretty silly.

Thanks,
--
Dominic


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D4B1755.1030301>