From owner-cvs-src@FreeBSD.ORG  Tue Jan 17 16:30:14 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id D5E8316A422; Tue, 17 Jan 2006 16:30:14 +0000 (GMT)
Date: Tue, 17 Jan 2006 16:30:14 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Doug Rabson <dfr@nlsystems.com>
Message-ID: <20060117163014.GA17831@FreeBSD.org>
References: <200512202106.jBKL6hNr035186@repoman.freebsd.org>
	<1CDDC33C-01D5-4AFE-99C0-DE848321D78B@nlsystems.com>
	<200601171111.01942.jhb@freebsd.org>
	<AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE@nlsystems.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <AFC3FB6C-AEE0-483B-919C-EDCD6DC26EAE@nlsystems.com>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org,
	John Baldwin <jhb@freebsd.org>
Subject: Re: cvs commit: src/sys/pci agp.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 16:30:15 -0000

On Tue, Jan 17, 2006 at 04:19:07PM +0000, Doug Rabson wrote:
> 
> On 17 Jan 2006, at 16:11, John Baldwin wrote:
> 
> >On Tuesday 17 January 2006 06:51, Doug Rabson wrote:
> >>On 20 Dec 2005, at 21:06, John Baldwin wrote:
> >>>jhb         2005-12-20 21:06:43 UTC
> >>>
> >>>  FreeBSD src repository
> >>>
> >>>  Modified files:
> >>>    sys/pci              agp.c
> >>>  Log:
> >>>  Change the agp_find_device() to return the first agp device that
> >>>has been
> >>>  attached to a driver rather than always returning agp0.
> >>
> >>According to Coverity, this introduces a memory leak
> >>(devclass_get_devices() allocates memory).
> >
> >That it does.  How about this fix:
> 
> Looks good to me.

Except for style bugs (parens around return value).

./danfe