From owner-freebsd-acpi@FreeBSD.ORG Fri Jun 10 03:22:01 2005 Return-Path: X-Original-To: freebsd-acpi@freebsd.org Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 721E116A41C for ; Fri, 10 Jun 2005 03:22:01 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 004B543D49 for ; Fri, 10 Jun 2005 03:22:00 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [192.168.42.23] (andersonbox3.centtech.com [192.168.42.23]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id j5A3LxMM022546 for ; Thu, 9 Jun 2005 22:21:59 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <42A9073E.8070109@centtech.com> Date: Thu, 09 Jun 2005 22:21:34 -0500 From: Eric Anderson User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.8) Gecko/20050603 X-Accept-Language: en-us, en MIME-Version: 1.0 To: freebsd-acpi@freebsd.org References: <200506032012.j53KCC5k077879@repoman.freebsd.org> <42A6DA72.2070105@centtech.com> <42A73FEE.4090202@root.org> <42A75772.2050400@centtech.com> In-Reply-To: <42A75772.2050400@centtech.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: src/sys/dev/acpica acpi.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2005 03:22:01 -0000 Eric Anderson wrote: > Nate Lawson wrote: > >> Eric Anderson wrote: >> >>> Warner Losh wrote: >>> >>>> imp 2005-06-03 20:12:12 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> sys/dev/acpica acpi.c Log: >>>> In newbus land, ivars can only be accessed for direct child, or when >>>> the driver has unholy private knowledge of its great-*cgrandchildren. >>>> The ACPI allocation routine lacked such knowledge when it tried to do >>>> a default allocation for all descendants, rather than just its >>>> immeidate children, so would access grandchild's ivar in an unsafe >>>> way. This could lead to a panic when devices were present which had >>>> no addresses setup by the BIOS, but which were later allocated in a >>>> lazy manner via pci_alloc_map. As such, only do the default >>>> allocation adjustments for immediate children. The manner that >>>> acpi_sysres_find accesses the resource list, used later in >>>> acpi_alloc_resource, is safe and proper so no additional test is >>>> needed there. >>>> This fixes a panic when probing an disabled ata controller on some >>>> newer intel blades. >>>> Reported by: dwhite >>>> Revision Changes Path >>>> 1.214 +1 -1 src/sys/dev/acpica/acpi.c >>> >>> >>> >>> >>> Warner - I owe you a beer! I believe this commit got my Dell D610 >>> laptop (and maybe the D600's?) to go into S3 mode, which prior to >>> this commit it would power off the machine instead of going into S3. >> >> >> >> Great. It should be MFCd also. > > > Awesome!! Now does anyone have any hints on how I can start looking at > why it powers off instead of resumes? Screen is blank the whole time so > it's hard to tell whats happening. Of course, as soon as I send this email, it *STOPS* working. I cannot figure this out - it successfully went into suspend, and now I can't get it to go into it. I haven't recompiled anything, haven't changed any settings, nothing. I'm so lost.. Does anyone have any hints, clues, etc? I have a spare D610 now to experiment on - I'm open to suggestions.. Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology A lost ounce of gold may be found, a lost moment of time never. ------------------------------------------------------------------------