From owner-freebsd-bugs Sat Apr 11 11:45:07 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA14666 for freebsd-bugs-outgoing; Sat, 11 Apr 1998 11:45:07 -0700 (PDT) (envelope-from owner-freebsd-bugs@FreeBSD.ORG) Received: from ifi.uio.no (0@ifi.uio.no [129.240.64.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA14591; Sat, 11 Apr 1998 11:44:04 -0700 (PDT) (envelope-from dag-erli@ifi.uio.no) Received: from hrotti.ifi.uio.no (2602@hrotti.ifi.uio.no [129.240.64.15]) by ifi.uio.no (8.8.8/8.8.7/ifi0.2) with ESMTP id UAA11257; Sat, 11 Apr 1998 20:43:36 +0200 (MET DST) Received: (from dag-erli@localhost) by hrotti.ifi.uio.no ; Sat, 11 Apr 1998 20:43:35 +0200 (MET DST) Mime-Version: 1.0 To: freebsd-bugs@hub.freebsd.org, freebsd-hackers@FreeBSD.ORG Followup-to: freebsd-hackers@freebsd.org Subject: Re: kern/6099: LPIP to slow machine causes hang References: <199804111550.IAA18671@hub.freebsd.org> Organization: Gutteklubben Terrasse / KRST / PUMS / YASMW X-url: http://www.stud.ifi.uio.no/~dag-erli/ X-Stop-Spam: http://www.cauce.org From: dag-erli@ifi.uio.no (Dag-Erling Coidan =?iso-8859-1?Q?Sm=F8rgrav?= ) Date: 11 Apr 1998 20:43:34 +0200 In-Reply-To: dag-erli@ifi.uio.no's message of "Sat, 11 Apr 1998 08:50:02 -0700 (PDT)" Message-ID: Lines: 32 X-Mailer: Gnus v5.5/Emacs 19.34 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by hub.freebsd.org id LAA14613 Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org dag-erli@ifi.uio.no (Dag-Erling Coidan Smørgrav ) writes: > Peter Jeremy writes: > > The problem with LPIP is that enabling an lpt port for LPIP does not > > update net_imask. This means that LPIP interrupts can break splimp() > > critical regions - which includes all mbuf handling. > > > > The following patches correct the problem in 2.2.5R. The problem also > > exists in older versions of 2.2, -stable and -current. The same patches > > > > [patch deleted] > > Here's a patch for 2.2.6-STABLE: > > [patch deleted] > > I haven't had time to test it thoroughly yet though. I applied the patch on Valinor (P166, 128MB/9GB, 2.2.6-STABLE) and Helen (ThinkPad 380E, 16MB/2GB, 2.2.6-STABLE) and ran 'rcsh valinor cat /dev/urandom > /usr/tmp/urandom' from Helen successfully for five minutes. The throughput seems to have gone down 15% or 20% after the patch, from ~90 kBps to ~75 kBps, but at least the machine does not hang and it is possible to do something while it's transferring. As I type this, Helen is downloading the entire package collection from 2.2.6 over LPIP (it's gone through packages-2.2.6/All/[a-e]* already) I suggest that somebody commit the patch to -current now, and if it does not break anything and everybody is happy I'll merge lpt.c from -current into -stable and close the affected PRs in a while. -- fprintf(stderr, "I have a closed mind. It helps keeping the rain out.\n"); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message