Date: Mon, 27 May 2002 18:58:54 +0100 From: Dominic Marks <dominic_marks@btinternet.com> To: David O'Brien <obrien@FreeBSD.org> Cc: "David W. Chapman Jr." <dwcjr@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/nmap Makefile distinfo Message-ID: <20020527185854.A79542@host217-39-111-112.in-addr.btop> In-Reply-To: <20020527103350.A50482@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, May 27, 2002 at 10:33:50AM -0700 References: <200205211626.g4LGQ4k04278@freefall.freebsd.org> <20020527103350.A50482@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 27, 2002 at 10:33:50AM -0700, David O'Brien wrote:
> On Tue, May 21, 2002 at 09:26:04AM -0700, David W. Chapman Jr. wrote:
> > dwcjr 2002/05/21 09:26:04 PDT
> >
> > Modified files:
> > security/nmap Makefile distinfo
> > Log:
> > Update to the latest
> >
> > PR: 38305
> > Submitted by: maintainer
>
> Don't you portlint things?
> OK: checking Makefile.
> WARN: possible direct use of command "echo" found. use ${ECHO} instead.
> FATAL: extra item "PLIST" placed in the PORTNAME section.
> FATAL: extra item "MAINTAINER" placed in the PORTNAME section.
> WARN: unless this is a master port, PORTNAME has to be set by "=", not by
> "?=".
> WARN: extra item placed in the MAINTAINER section.
Sorry, I didn't know variable placement was important. I shall use
portlint in future.
> Or santity check things? What is the purpose of
> PLIST= pkg-plist
It was used when generating the package list based on the option of
no-gui or gui. It's now redudant, since that was an incorrect
"feature" in the first place.
> Or the fact there is an explicit nmapfe port for the GUI.
I didn't know this at the time of my work, I noticed that the
configure contained errors. I have since fixed my port, the PR
ports/38496 addresses this problem. I see you committed fixes for the
problems you identified, so it can be closed now.
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe cvs-all" in the body of the message
Thanks
--
Dominic
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020527185854.A79542>