From owner-cvs-all Mon May 27 10:59:17 2002 Delivered-To: cvs-all@freebsd.org Received: from host217-39-111-112.in-addr.btopenworld.com (host217-39-111-112.in-addr.btopenworld.com [217.39.111.112]) by hub.freebsd.org (Postfix) with ESMTP id 3A4D437B408; Mon, 27 May 2002 10:59:01 -0700 (PDT) Received: by host217-39-111-112.in-addr.btopenworld.com (Postfix, from userid 1001) id 7E5D04E7; Mon, 27 May 2002 18:58:54 +0100 (BST) Date: Mon, 27 May 2002 18:58:54 +0100 From: Dominic Marks To: David O'Brien Cc: "David W. Chapman Jr." , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/nmap Makefile distinfo Message-ID: <20020527185854.A79542@host217-39-111-112.in-addr.btop> References: <200205211626.g4LGQ4k04278@freefall.freebsd.org> <20020527103350.A50482@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020527103350.A50482@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, May 27, 2002 at 10:33:50AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, May 27, 2002 at 10:33:50AM -0700, David O'Brien wrote: > On Tue, May 21, 2002 at 09:26:04AM -0700, David W. Chapman Jr. wrote: > > dwcjr 2002/05/21 09:26:04 PDT > > > > Modified files: > > security/nmap Makefile distinfo > > Log: > > Update to the latest > > > > PR: 38305 > > Submitted by: maintainer > > Don't you portlint things? > OK: checking Makefile. > WARN: possible direct use of command "echo" found. use ${ECHO} instead. > FATAL: extra item "PLIST" placed in the PORTNAME section. > FATAL: extra item "MAINTAINER" placed in the PORTNAME section. > WARN: unless this is a master port, PORTNAME has to be set by "=", not by > "?=". > WARN: extra item placed in the MAINTAINER section. Sorry, I didn't know variable placement was important. I shall use portlint in future. > Or santity check things? What is the purpose of > PLIST= pkg-plist It was used when generating the package list based on the option of no-gui or gui. It's now redudant, since that was an incorrect "feature" in the first place. > Or the fact there is an explicit nmapfe port for the GUI. I didn't know this at the time of my work, I noticed that the configure contained errors. I have since fixed my port, the PR ports/38496 addresses this problem. I see you committed fixes for the problems you identified, so it can be closed now. > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe cvs-all" in the body of the message Thanks -- Dominic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message