From owner-freebsd-current@FreeBSD.ORG Wed Aug 26 13:32:10 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B694A106564A for ; Wed, 26 Aug 2009 13:32:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 894528FC28 for ; Wed, 26 Aug 2009 13:32:10 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 354EE46B65; Wed, 26 Aug 2009 09:32:10 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 57A4F8A02B; Wed, 26 Aug 2009 09:32:09 -0400 (EDT) From: John Baldwin To: Bruce Cran Date: Wed, 26 Aug 2009 08:44:16 -0400 User-Agent: KMail/1.9.7 References: <20090824230145.75824e5f@gluon.draftnet> In-Reply-To: <20090824230145.75824e5f@gluon.draftnet> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200908260844.16767.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 26 Aug 2009 09:32:09 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: current@freebsd.org Subject: Re: patches to fix "ps -M" as used in crashinfo(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2009 13:32:10 -0000 On Monday 24 August 2009 6:01:45 pm Bruce Cran wrote: > I've recently been debugging a series of problems with running ps(1) on > crash dumps, and now have a couple of patches: the bugs cause > ps(1) to crash while crashinfo(8) is being run during boot, dumping a > 1GB ps.core file in the root filesystem. > > The patches are at > http://www.cran.org.uk/~brucec/freebsd/pr137890.kvm_proc.c.diff and > http://www.cran.org.uk/~brucec/freebsd/pr137890.ps.c.diff > > The problem with ps.c is that like pkill(1) and w(1), they all > initialize the execfile argument to kvm_open or kvm_openfiles to > "/dev/null" instead of NULL, causing the default usage of "ps > -M /var/crash/vmcore.x" to fail because libkvm fails to > fstat /dev/null. They only work if "-N" is also specified. Note that crashinfo specifies both -M and -N: echo "------------------------------------------------------------------------" echo "ps -axl" echo ps -M $VMCORE -N $KERNEL -axl echo I'm not sure that 'ps -M blah' without '-N' should really work. Also, I'm not sure how fstat() of /dev/null could fail? The kvm_nlist() bug in libkvm should probably still be fixed, and the ngroups one you might want to poke brooks@ about. -- John Baldwin